1451124 - write a WPT verifying workers get their own client ID

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, enhancement, P2)

Description

[Ben Kelly [:bkelly, not reviewing]]

I have an interop report from a site related to worker client ID values.  The site is expecting the chrome's behavior where FetchEvent.clientId values coming from a dedicated worker match the owning document's clientId.  This is not correct given the current spec.

In addition, it seems edge has matched chrome's non-spec behavior here.

We should get a WPT establishing the correct spec behavior ASAP to prevent further interop issues in the future.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Add a WPT test to verify dedicated workers have a separate client ID from their owning document. r=asuth

Andrew, this is a WPT test that verifies a dedicated worker has its own client ID and does not share its parent window's client ID.  The spec requires the FetchEvent.clientId to be the id for the "request's client":

https://fetch.spec.whatwg.org/#concept-request-client

I can't find where "request's client" is explicitly set, but things like step 1 here clearly expect it to hold worker clients, etc:

https://fetch.spec.whatwg.org/#fetching

https://treeherder.mozilla.org/#/jobs?repo=try&revision=54cb31d450e1b2d4978aa4ae6b5ff2db1281bd4a

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8964697 [details] [diff] [review]
Add a WPT test to verify dedicated workers have a separate client ID from their owning document. r=asuth

Review of attachment 8964697 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/web-platform/tests/service-workers/service-worker/worker-client-id.https.html
@@ +34,5 @@
> +
> +promise_test(async function(t) {
> +  const script = './resources/worker-client-id-worker.js';
> +  const scope = './resources/worker-client-id';
> +  const frame = scope + '/frame.html';

Per IRC discussion (thanks for clarifying!), please either explicitly add a comment that this is expected to 404 or respondWith an empty doc like you alternately proposed.  Thanks!

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Add a WPT test to verify dedicated workers have a separate client ID from their owning document. r=asuth

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aed7d4d9be32
Add a WPT test to verify dedicated workers have a separate client ID from their owning document. r=asuth

Comment 5

[Jake Archibald]

Yep, Chrome and Edge are wrong here. Thanks for creating a test.

Comment 6

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/aed7d4d9be32

Comment 7

[Jake Archibald]

Safari also gets this wrong. Demo: https://worker-client-id-demo.glitch.me/

Comment 8

[Jake Archibald]

https://bugs.chromium.org/p/chromium/issues/detail?id=828777
https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/16738775/
https://bugs.webkit.org/show_bug.cgi?id=184294

Comment 9

[Ben Kelly [:bkelly, not reviewing]]

James, is the wpt sync bot operational at the moment?  I was hoping to get this synced to the other browsers.

Comment 10

[James Graham [:jgraham]]

It's hit a case it doesn't handle, which blocks subsequent upstreams. I'm already on it, hopefully it will be unblocked today.

Comment 11

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/10418 for changes under testing/web-platform/tests