Closed Bug 1451127 Opened 2 years ago Closed 7 months ago

Use UNIFIED_SOURCES where possible in security/sandbox/linux

Categories

(Core :: Security: Process Sandboxing, enhancement, P3)

60 Branch
Unspecified
Linux
enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: jld, Assigned: Srujana.htt121)

Details

Attachments

(1 file)

We're not using unified builds in the Linux sandbox, and we probably could be.  There might be a few problems with name conflicts in statics / anonymous namespaces but probably nothing insoluble.  Even if the Chromium source files cause problems that can't be fixed without large changes, we might still be able to glue our own code together.
Priority: -- → P3

Hi, I am working with David parks for sandbox Testing project and he has assigned me this issue. he asked me to take this bug using the button next to assignee but I cant find any such button. Can someone assign this bug to me? Thank you.

Assignee: nobody → Srujana.htt121

Objects in SOURCES have flags. But I am not able to add flags for UNIFIED_SOURCES.
Is there a way to add flags in the later or should I keep the files needing flags in the former?

Correct me if I am wrong.

SOURCES use "StrictOrderingOnAppendListWithFlagsFactory" base class and UNIFIED_SOURCES use "StrictOrderingOnAppendList" base class. As of now I do not think there is an option to add flags for the later. So the files requiring flags should be in SOURCES.

Flags: needinfo?(davidp99)

Added files to UNIFIED_SOURCES and removed conflicts. Files that required flags still remain in SOURCES. . SOURCES use "StrictOrderingOnAppendListWithFlagsFactory" base class and UNIFIED_SOURCES use "StrictOrderingOnAppendList" base class. As of now I do not think there is an option to add flags for the later. So the files requiring flags are kept in SOURCES.

Attachment #9051515 - Attachment description: Issue : 1451127 : Use UNIFIED_SOURCES where possible in security/sandbox/linux - Added files to UNIFIED_SOURCES and removed conflicts. Files that required flags still remain in SOURCES. → Issue : 1451127 : Added files to UNIFIED_SOURCES and removed conflicts. Files that required flags still remain in SOURCES.
Attachment #9051515 - Attachment description: Issue : 1451127 : Added files to UNIFIED_SOURCES and removed conflicts. Files that required flags still remain in SOURCES. → Bug 1451127 : Added files to UNIFIED_SOURCES and removed conflicts. Files that required flags still remain in SOURCES.
Attachment #9051515 - Attachment description: Bug 1451127 : Added files to UNIFIED_SOURCES and removed conflicts. Files that required flags still remain in SOURCES. → Bug 1451127 : Added files to UNIFIED_SOURCES and removed conflicts.
Flags: needinfo?(davidp99)
Keywords: checkin-needed

Pushed by dvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c74d96f38aeb
Added files to UNIFIED_SOURCES and removed conflicts. r=handyman

Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
https://hg.mozilla.org/projects/ash/rev/c74d96f38aeb52d0c5af9d3f61ca2217b48f3294
Bug 1451127 :  Added files to UNIFIED_SOURCES and removed conflicts. r=handyman
You need to log in before you can comment on or make changes to this bug.