1451127 - Use UNIFIED_SOURCES where possible in security/sandbox/linux

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, enhancement, P3)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

We're not using unified builds in the Linux sandbox, and we probably could be.  There might be a few problems with name conflicts in statics / anonymous namespaces but probably nothing insoluble.  Even if the Chromium source files cause problems that can't be fixed without large changes, we might still be able to glue our own code together.

Comment 1

[Srujana Peddinti [:srujana121]]

Hi, I am working with David parks for sandbox Testing project and he has assigned me this issue. he asked me to take this bug using the button next to assignee but I cant find any such button. Can someone assign this bug to me? Thank you.

Comment 2

[Srujana Peddinti [:srujana121]]

Objects in SOURCES have flags. But I am not able to add flags for UNIFIED_SOURCES.
Is there a way to add flags in the later or should I keep the files needing flags in the former?

Comment 3

[Srujana Peddinti [:srujana121]]

Correct me if I am wrong.

SOURCES use "StrictOrderingOnAppendListWithFlagsFactory" base class and UNIFIED_SOURCES use "StrictOrderingOnAppendList" base class. As of now I do not think there is an option to add flags for the later. So the files requiring flags should be in SOURCES.

Comment 4

[Srujana Peddinti [:srujana121]]

Attachment: Bug 1451127 : Added files to UNIFIED_SOURCES and removed conflicts.

Added files to UNIFIED_SOURCES and removed conflicts. Files that required flags still remain in SOURCES. . SOURCES use "StrictOrderingOnAppendListWithFlagsFactory" base class and UNIFIED_SOURCES use "StrictOrderingOnAppendList" base class. As of now I do not think there is an option to add flags for the later. So the files requiring flags are kept in SOURCES.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c74d96f38aeb
Added files to UNIFIED_SOURCES and removed conflicts. r=handyman

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/c74d96f38aeb

Comment 7

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/projects/ash/rev/c74d96f38aeb52d0c5af9d3f61ca2217b48f3294
Bug 1451127 :  Added files to UNIFIED_SOURCES and removed conflicts. r=handyman