1451132 - Provide an option to close the current tab when closing the window

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement, P5)

Description

[Gennaro Prota]

Attachment: AllOrCurrent.png

Most times, when the user gives the command to close a window with multiple tabs, he/she wants to close the current tab only. Internet Explorer shows the right window to fix the action (see attached image). Firefox does not. Please, consider providing a choice similar to that of IE.

Comment 1

[jaime [:jabramson]]

Attachment: Bug 1451132 - Provide option to close current tab on quit r=cmkm,mconley

Comment 2

[jaime [:jabramson]]

Attachment: screenshot of the updated button order in this patch

Comment 3

[jaime [:jabramson]]

Hi, I'm hoping to get an a11y review of my patch for this ticket (https://phabricator.services.mozilla.com/D223374). When a macOS (or any Unix) user has multiple tabs open and uses the keyboard shortcut to quit (cmd+Q), this patch adds a new "close current tab" button to the dialog that opens. It also reorders buttons so that "close current tab" appears next to the quit button instead of the cancel button. I'd like to make sure there aren't any accessibility concerns with this reordering. This is part of the Desktop UX Fundamentals project that wraps at the end of the year. Thanks!

Comment 4

[Anna Yeddi [:ayeddi]]

Thank you, :jabramson! I commented in the Phab - the dialog is implemented in an accessible way and you even have thought through the keyboard-only flow to return the focus to the previous focus position after a shortcut-triggered dialog is dismissed. Thank you so much for working on this!

The dialog itself would also help users with cognitive disabilities to ensure they're not missing important information and make it easier to manage tabs (not closing the whole windows by a mistake).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbecdb8245d8
Provide option to close current tab on quit r=fluent-reviewers,reusable-components-reviewers,mconley,settings-reviewers,mossop,accessibility-frontend-reviewers,mstriemer,ayeddi

Comment 6

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/fbecdb8245d8

Comment 7

[Donal Meehan [:dmeehan]]

:jabramson could you consider nominating this for a release note? (Process info)

Comment 8

[jaime [:jabramson]]

Release Note Request
[Why is this notable]: This patch adds a new button to the dialog that displays on Unix (including macOS) platforms when the Quit keyboard shortcut (cmd+Q) is used and multiple tabs are open, giving users the option to close only the current tab instead of quit the browser.
[Affects Firefox for Android]: no
[Suggested wording]: Firefox gives Unix users the option to close the current tab if the Quit keyboard shortcut is used with multiple tabs open.
[Links (documentation, blog post, etc)]:

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Added to the Fx135 relnotes.