1451205 - ts_paint regression

Status: RESOLVED WORKSFORME

(Core :: Graphics: WebRender, enhancement, P1)

Description

[Jeff Muizelaar [:jrmuizel]]

https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&newProject=try&newRevision=e450e7797b7f8d5d8d286ed72e6fbc1676728db2&framework=1&filter=windows10%20ts_paint&selectedTimeRange=172800

Comment 1

[Jeff Muizelaar [:jrmuizel]]

We should try to get a profile of this.

Comment 2

[Aria Beingessner [:Gankra]]

Results of profiling and investigation:

We spend about half of our startup time blocked on D3D shader compilation. Ostensibly sotaro's work on pre-compiling shaders to bytecode should eliminate this, at which point we should revisit this benchmark.

Comment 3

[Aria Beingessner [:Gankra]]

profile: https://perfht.ml/2GXpJXC

profile where we disabled the Angle Thread Pool to get better introspection into what was executing (at the expense of overall slower runtime, making the profile less accurate in aggregate): https://perfht.ml/2GYlDhX

Comment 4

[Kartikaya Gupta (email:[e-mail])]

It's not clear to me which test this bug is referring to, there is no "tspaint" talos test, and the link in comment 0 doesn't work any more. If it's tpaint, we have bug 1416650 on file for that. Anyway I'm going to close this bug as invalid and file new bugs for any outstanding talos regressions that don't have bugs.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Oh, the link in comment 0 did eventually load, it just took a long time. That indicates the test is actually called "ts_paint". The latest data can be seen here:

https://treeherder.mozilla.org/perf.html#/graphs?series=autoland,1646249,1,1&series=autoland,1683321,1,1&series=autoland,1651464,1,1&series=autoland,1684579,1,1

which shows that both Linux and Windows have comparable numbers with and without WR enabled, as of sometime around May 31. Closing this as WFM instead.