Closed Bug 1451242 Opened 2 years ago Closed 2 years ago

Use this.$ instead of this.document.getElementById in CustomizeMode.jsm

Categories

(Firefox :: Toolbars and Customization, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: dao, Assigned: manishkk)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(1 file, 1 obsolete file)

From bug 1450279 comment 3:

> ::: browser/components/customizableui/CustomizeMode.jsm:105
> (Diff revision 1)
> >  
> >    // There are two palettes - there's the palette that can be overlayed with
> >    // toolbar items in browser.xul. This is invisible, and never seen by the
> >    // user. Then there's the visible palette, which gets populated and displayed
> >    // to the user when in customizing mode.
> > -  this.visiblePalette = this.document.getElementById(kPaletteId);
> > +  this.visiblePalette = this.$(kPaletteId);
> 
> Can you file a good-first-bug to update the remaining uses of
> `this.document.getElementById` in CustomizeMode.jsm to use this new helper
> thing?
Assignee: nobody → 1991manish.kumar
Attached patch Patch_Bug1451242 (obsolete) — Splinter Review
Please review.

Thanks
Attachment #8965117 - Flags: review?(dao+bmo)
Comment on attachment 8965117 [details] [diff] [review]
Patch_Bug1451242

Review of attachment 8965117 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/customizableui/CustomizeMode.jsm
@@ +150,4 @@
>    },
>  
>    $(id) {
> +    return this.$(id);

nah, you have to keep this line unchanged.
Attachment #8965117 - Flags: review?(dao+bmo) → review?(gijskruitbosch+bugs)
PLease review
Attachment #8965117 - Attachment is obsolete: true
Attachment #8965117 - Flags: review?(gijskruitbosch+bugs)
Attachment #8965241 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8965241 [details] [diff] [review]
PatchV2_Bug1451242

Review of attachment 8965241 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks!
Attachment #8965241 - Flags: review?(gijskruitbosch+bugs) → review+
Keywords: checkin-needed
Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2fc4f5aef58f
Use this.$ instead of this.document.getElementById in CustomizeMode.jsm r=Gijs
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/2fc4f5aef58f
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.