1451242 - Use this.$ instead of this.document.getElementById in CustomizeMode.jsm

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, enhancement)

Description

[Dão Gottwald [:dao]]

From bug 1450279 comment 3:

> ::: browser/components/customizableui/CustomizeMode.jsm:105
> (Diff revision 1)
> >  
> >    // There are two palettes - there's the palette that can be overlayed with
> >    // toolbar items in browser.xul. This is invisible, and never seen by the
> >    // user. Then there's the visible palette, which gets populated and displayed
> >    // to the user when in customizing mode.
> > -  this.visiblePalette = this.document.getElementById(kPaletteId);
> > +  this.visiblePalette = this.$(kPaletteId);
> 
> Can you file a good-first-bug to update the remaining uses of
> `this.document.getElementById` in CustomizeMode.jsm to use this new helper
> thing?

Comment 1

[Manish [:manishkk]]

Attachment: Patch_Bug1451242

Please review.

Thanks

Comment 2

[Ekanan Ketunuti]

Comment on attachment 8965117 [details] [diff] [review]
Patch_Bug1451242

Review of attachment 8965117 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/customizableui/CustomizeMode.jsm
@@ +150,4 @@
>    },
>  
>    $(id) {
> +    return this.$(id);

nah, you have to keep this line unchanged.

Comment 3

[Manish [:manishkk]]

Attachment: PatchV2_Bug1451242

PLease review

Comment 4

[:Gijs (he/him)]

Comment on attachment 8965241 [details] [diff] [review]
PatchV2_Bug1451242

Review of attachment 8965241 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2fc4f5aef58f
Use this.$ instead of this.document.getElementById in CustomizeMode.jsm r=Gijs

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/2fc4f5aef58f