Closed
Bug 1451257
Opened 8 years ago
Closed 8 years ago
[wpt-sync] Sync PR 10303 - Simplify assert_throws in two places where error messages were passed
Categories
(Core :: DOM: Core & HTML, enhancement, P4)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 10303 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/w3c/web-platform-tests/pull/10303
Details from upstream follow.
Philip Jägenstedt <foolip@chromium.org> wrote:
> Simplify assert_throws in two places where error messages were passed
>
> This was discovered in
> https://chromium-review.googlesource.com/c/chromium/src/+/980757 by
> letting assert_throws also check that the message matches. That change
> itself isn't a good idea, but it's still just as well to use plain
> TypeErrors here to not make it seems like more is being tested than in
> fact is.
>
> Change-Id: I8f964e9b25cc94942cb86f3ee0017530f230e04a
> Reviewed-on: https://chromium-review.googlesource.com/995192
> WPT-Export-Revision: f7fa105eca396a6cd7a5a2bc3ae01e9b2f4feb73
| Reporter | ||
Updated•8 years ago
|
Component: web-platform-tests → DOM
Product: Testing → Core
| Reporter | ||
Comment 1•8 years ago
|
||
| Reporter | ||
Comment 2•8 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=70e91b6cf3c0f4413607f1b80f9283319d82916f
| Reporter | ||
Comment 3•8 years ago
|
||
Ran 3 tests and 98 subtests
OK : 3
PASS : 93
FAIL : 5
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/481f211d7f1c
[wpt PR 10303] - Simplify assert_throws in two places where error messages were passed, a=testonly
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
| Assignee | ||
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•