1451331 - bugprone-forward-declaration-namespace readability-static-accessed-through-instance doesn't exist in our current version of clang-tidy

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

readability-static-accessed-through-instance is 6.0 only


and bugprone-forward-declaration-namespace was called misc-forward-declaration-namespace in 5.0 (renamed in 6.0)

http://releases.llvm.org/6.0.0/tools/clang/tools/extra/docs/ReleaseNotes.html

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1451331 - Fix the name of the checkers as we are using clang-tidy 5.0

Review commit: https://reviewboard.mozilla.org/r/233650/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233650/

Comment 2

[Code Review Bot [:reviewbot]]

Comment on attachment 8964924 [details]
Bug 1451331 - Fix the name of the checkers as we are using clang-tidy 5.0

https://reviewboard.mozilla.org/r/233650/#review239258


Code analysis found 2 defects in this patch:
 - 2 defects found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: tools/clang-tidy/config.yaml:9
(Diff revision 1)
>  # in order to have consistency across the used checkers.
>  # All the clang checks used by the static-analysis tools.
>  clang_checkers:
>   - name: -*
>     publish: !!bool no
> - - name: bugprone-forward-declaration-namespace
> +# Name with clang tidy 6.0. We are currently using 5.0

Warning: Comment not indented like content [yamllint: comments-indentation]

::: tools/clang-tidy/config.yaml:80
(Diff revision 1)
>     publish: !!bool no
>   - name: readability-redundant-string-cstr
>     publish: !!bool yes
>   - name: readability-redundant-string-init
>     publish: !!bool yes
> - - name: readability-static-accessed-through-instance
> +# Only available from clang tidy 6.0. We are currently using 5.0

Warning: Comment not indented like content [yamllint: comments-indentation]

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8964924 [details]
Bug 1451331 - Fix the name of the checkers as we are using clang-tidy 5.0

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/233650/diff/1-2/

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8964924 [details]
Bug 1451331 - Fix the name of the checkers as we are using clang-tidy 5.0

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/233650/diff/2-3/

Comment 5

[Andi [:andi]]

Comment on attachment 8964924 [details]
Bug 1451331 - Fix the name of the checkers as we are using clang-tidy 5.0

https://reviewboard.mozilla.org/r/233650/#review239546

Comment 6

[Andi [:andi]]

Comment on attachment 8964924 [details]
Bug 1451331 - Fix the name of the checkers as we are using clang-tidy 5.0

https://reviewboard.mozilla.org/r/233650/#review239548

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6457ac324bf
Fix the name of the checkers as we are using clang-tidy 5.0 r=andi

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b6457ac324bf