Debugger release v19.5 for FF60 Beta

RESOLVED FIXED

Status

enhancement
P3
normal
RESOLVED FIXED
a year ago
10 months ago

People

(Reporter: jdescottes, Assigned: jdescottes)

Tracking

(Blocks 1 bug)

unspecified

Firefox Tracking Flags

(firefox60 fixed, firefox61 unaffected)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Comment 3

a year ago
(Assignee)

Comment 5

a year ago
Attachment #8964948 - Attachment is obsolete: true
(Assignee)

Updated

a year ago
Attachment #8964966 - Attachment is obsolete: true
(Assignee)

Updated

a year ago
Attachment #8964989 - Flags: review?(jlaster)
Comment on attachment 8964989 [details] [diff] [review]
patch-debugger-v19.5-rc3.patch

Looks good

- member expressions work
- type script mode works
- stepping really quickly works

Thanks!
Attachment #8964989 - Flags: review?(jlaster) → review+
(Assignee)

Comment 9

a year ago
Comment on attachment 8964989 [details] [diff] [review]
patch-debugger-v19.5-rc3.patch

Approval Request Comment
[Feature/Bug causing the regression]: N/A
[User impact if declined]: fixes several debugger bugs (see list in comment 2)
[Is this code covered by automated tests?]: yes, and both Jason and I manually tested it
[Has the fix been verified in Nightly?]: yes, all the commits backported here landed in other releases of the debugger in Nightly
[Needs manual test from QE? If yes, steps to reproduce]:  no
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: no
[Why is the change risky/not risky?]: it only affects the debugger
[String changes made/needed]: none
Attachment #8964989 - Flags: approval-mozilla-beta?
Can you describe the impact of the fixes?  Are these regressions?  I can't really tell from the one-line commit messages what this is doing or why these are must-haves in late(ish) beta.  Thanks.
Flags: needinfo?(jdescottes)
(Assignee)

Comment 11

a year ago
Forwarding the ni? to Jason who will know more.

My understanding:
- Support typescript mode (#5574) : nice to have
- Allow dbg in the browser toolbox (#5685) : nice to have for developers
- Fix a couple of stepping typeErrors (#5680) + 
  Fix backport of c0b84b9 against stepOver regression + 
  Fix empty debugger (partial backport of 9757bee) : 
    all 3 avoid to get a blank debugger when stepping quickly (I assume this is a regression, but can't tell you from which commit, maybe Jason knows)
Flags: needinfo?(jdescottes) → needinfo?(jlaster)
Support typescript mode is a bug fix for preview, we can't do inline code preview for files with flow or typescript types without it.
Flags: needinfo?(jlaster)
Allow dbg in the browser toolbox is the only nice to have
Comment on attachment 8964989 [details] [diff] [review]
patch-debugger-v19.5-rc3.patch

fair enough.  approved for 60.0b11
Attachment #8964989 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
https://hg.mozilla.org/releases/mozilla-beta/rev/48d402a628e6
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED

Updated

10 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.