1451337 - Debugger release v19.5 for FF60 Beta

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

List of commits to release:
- https://github.com/devtools-html/debugger.html/commit/051f4ad525d67a0eb0cdfd183cfc8b1c3058389e
- https://github.com/devtools-html/debugger.html/commit/23639f57e1b7750bb731860bdb258a76ed66240b
- https://github.com/devtools-html/debugger.html/commit/e8fdb9ae89193a9c776b27d1dc3801dd5b438582
- https://github.com/devtools-html/debugger.html/commit/ba8aa6934ccb839008b6baeafdb6eff9f668fe8b

Comment 1

[Julian Descottes [:jdescottes]]

Wrong link for first changeset:

- https://github.com/devtools-html/debugger.html/commit/3cb6f42865ab377a01f57caf5e5679780a374f75
- https://github.com/devtools-html/debugger.html/commit/23639f57e1b7750bb731860bdb258a76ed66240b
- https://github.com/devtools-html/debugger.html/commit/e8fdb9ae89193a9c776b27d1dc3801dd5b438582
- https://github.com/devtools-html/debugger.html/commit/ba8aa6934ccb839008b6baeafdb6eff9f668fe8b

Comment 2

[Julian Descottes [:jdescottes]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0405eaa51fc83b00dbe73362c9b5ea7fd63c46a2

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: patch-debugger-v19.5-rc1.patch

Comment 4

[Julian Descottes [:jdescottes]]

Added a partial backport of https://github.com/devtools-html/debugger.html/commit/9757bee9a2b3f2cdf98a2df112bfd352a6510b15

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: patch-debugger-v19.5-rc2.patch

Comment 6

[Julian Descottes [:jdescottes]]

try https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3c128e586e8965f43ee17ff4efaf6f7bca9a51c

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: patch-debugger-v19.5-rc3.patch

Slight change after the backport of https://github.com/devtools-html/debugger.html/pull/5680/commits/c0b84b998a793e2dcc3d5c3e21473bf38293dcb5 to avoid regressing step over.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e1fa9466776053e80320bbc9fc1b3578f6c19da7

Comment 8

[Jason Laster [:jlast]]

Comment on attachment 8964989 [details] [diff] [review]
patch-debugger-v19.5-rc3.patch

Looks good

- member expressions work
- type script mode works
- stepping really quickly works

Thanks!

Comment 9

[Julian Descottes [:jdescottes]]

Comment on attachment 8964989 [details] [diff] [review]
patch-debugger-v19.5-rc3.patch

Approval Request Comment
[Feature/Bug causing the regression]: N/A
[User impact if declined]: fixes several debugger bugs (see list in comment 2)
[Is this code covered by automated tests?]: yes, and both Jason and I manually tested it
[Has the fix been verified in Nightly?]: yes, all the commits backported here landed in other releases of the debugger in Nightly
[Needs manual test from QE? If yes, steps to reproduce]:  no
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: no
[Why is the change risky/not risky?]: it only affects the debugger
[String changes made/needed]: none

Comment 10

[Julien Cristau [:jcristau]]

Can you describe the impact of the fixes?  Are these regressions?  I can't really tell from the one-line commit messages what this is doing or why these are must-haves in late(ish) beta.  Thanks.

Comment 11

[Julian Descottes [:jdescottes]]

Forwarding the ni? to Jason who will know more.

My understanding:
- Support typescript mode (#5574) : nice to have
- Allow dbg in the browser toolbox (#5685) : nice to have for developers
- Fix a couple of stepping typeErrors (#5680) + 
  Fix backport of c0b84b9 against stepOver regression + 
  Fix empty debugger (partial backport of 9757bee) : 
    all 3 avoid to get a blank debugger when stepping quickly (I assume this is a regression, but can't tell you from which commit, maybe Jason knows)

Comment 12

[Jason Laster [:jlast]]

Support typescript mode is a bug fix for preview, we can't do inline code preview for files with flow or typescript types without it.

Comment 13

[Jason Laster [:jlast]]

Allow dbg in the browser toolbox is the only nice to have

Comment 14

[Julien Cristau [:jcristau]]

Comment on attachment 8964989 [details] [diff] [review]
patch-debugger-v19.5-rc3.patch

fair enough.  approved for 60.0b11

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/48d402a628e6