Closed Bug 1451411 Opened 6 years ago Closed 6 years ago

land WebSocket event listener leak test

Categories

(Core :: DOM: Networking, enhancement, P2)

enhancement

Tracking

()

RESOLVED DUPLICATE of bug 1451913

People

(Reporter: bkelly, Assigned: bkelly)

References

(Blocks 1 open bug)

Details

Attachments

(1 obsolete file)

I'd like to land a websocket leak test, but there is an assertion problem we need to fix in WebSocket first.
There are assertions around properly updating the window's count of web sockets with this test.  I tried a few things to fix it (calling Disconnect() from DisconnectFromOwner(), etc), but its still asserting.  Andrea, any chance you could look at this?
Flags: needinfo?(amarchesini)
Assignee: bkelly → nobody
Status: ASSIGNED → NEW
Blocks: 1451913
No longer blocks: 1451913
Assignee: nobody → bkelly
Status: NEW → ASSIGNED
Depends on: 1451913
Comment on attachment 8964993 [details] [diff] [review]
P2 Test that WebSocket does not leak through its event listeners. r=baku

Andrea, here is an event target leak test for WebSocket.  This passes once I fix the active websocket counter stuff.
Attachment #8964993 - Flags: review?(amarchesini)
Priority: -- → P2
Comment on attachment 8964993 [details] [diff] [review]
P2 Test that WebSocket does not leak through its event listeners. r=baku

I'm going to move this to bug 1451913.
Attachment #8964993 - Attachment is obsolete: true
Attachment #8964993 - Flags: review?(amarchesini)
No longer depends on: 1451913
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: needinfo?(amarchesini)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: