Closed Bug 1451530 Opened 2 years ago Closed 2 years ago

Pass the topobjdir to our Tup invocation

Categories

(Firefox Build System :: General, enhancement)

3 Branch
enhancement
Not set
normal

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: chmanchester, Assigned: chmanchester)

References

Details

Attachments

(1 file)

This avoids issues if there are multiple tup based objdirs present.
Comment on attachment 8965126 [details]
Bug 1451530 - Pass the current topobjdir to our Tup invocation.

https://reviewboard.mozilla.org/r/233812/#review240632

Since we no longer require make to build buildid.h and source-repo.h for the tup backend, we can probably move the tup invocation into mach. This would allow us to pass in the actual build target (so ./mach build subdir/foo.o works properly) or pass in topobjdir if there is no target. This works for now though.
Attachment #8965126 - Flags: review?(mshal) → review+
Comment on attachment 8965126 [details]
Bug 1451530 - Pass the current topobjdir to our Tup invocation.

https://reviewboard.mozilla.org/r/233812/#review240632

That's a good point, although we still have the build metrics and artifact code invoked from make, so let's move all that in a follow up.
Pushed by cmanchester@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/408c28463666
Pass the current topobjdir to our Tup invocation. r=mshal
https://hg.mozilla.org/mozilla-central/rev/408c28463666
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.