1451530 - Pass the topobjdir to our Tup invocation

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Chris Manchester (limited bugmail, email directly)]

This avoids issues if there are multiple tup based objdirs present.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1451530 - Pass the current topobjdir to our Tup invocation.

Review commit: https://reviewboard.mozilla.org/r/233812/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/233812/

Comment 2

[Michael Shal [:mshal]]

Comment on attachment 8965126 [details]
Bug 1451530 - Pass the current topobjdir to our Tup invocation.

https://reviewboard.mozilla.org/r/233812/#review240632

Since we no longer require make to build buildid.h and source-repo.h for the tup backend, we can probably move the tup invocation into mach. This would allow us to pass in the actual build target (so ./mach build subdir/foo.o works properly) or pass in topobjdir if there is no target. This works for now though.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8965126 [details]
Bug 1451530 - Pass the current topobjdir to our Tup invocation.

https://reviewboard.mozilla.org/r/233812/#review240632

That's a good point, although we still have the build metrics and artifact code invoked from make, so let's move all that in a follow up.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/408c28463666
Pass the current topobjdir to our Tup invocation. r=mshal

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/408c28463666