1451586 - WebExtension themes do not apply on new Firefox window

Status: RESOLVED WORKSFORME

(WebExtensions :: Themes, defect, P2)

Description

[noxphasma]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180404100127

Steps to reproduce:

Install a WebExtension Theme, I'm using this (https://addons.mozilla.org/de/firefox/addon/arc-dark-theme-webextension/). Then open a new Firefox window.


Actual results:

The WebExtension Theme does not apply to the new Firefox window.


Expected results:

The WebExtension Theme should apply to the new Firefox window.

Comment 1

[Tim Nguyen :ntim]

Thanks for filing this bug. I can only reproduce this when you have a lightweight theme or the dark/light theme selected in the add-ons manager. I can't reproduce this with the default theme selected in the add-ons manager.

noxphasma, what theme do you have selected in the "Themes" section when this happens?

Comment 2

[Tim Nguyen :ntim]

I found a quick and dirty fix if my assumption in comment 1 is correct (that a theme different than the default is selected in the add-ons manager).

Adding:
LightweightThemeManager.currentTheme = null;

after this line: https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-theme.js#98

fixes the issue.

Comment 3

[noxphasma]

(In reply to Tim Nguyen :ntim from comment #1)
> noxphasma, what theme do you have selected in the "Themes" section when this
> happens?

I have the dark theme activated, which is needed for that specific WebExtension, otherwise the Text is too dark. I was trying with the light theme as well, which showed the same behaviour. I haven't tried the default theme probably.

Comment 4

[noxphasma]

I've checked it with the default theme and you are right it seems to works with the default theme.

Comment 5

[Tim Nguyen :ntim]

Thanks for confirming!

Comment 7

[Tomislav Jovanovic :zombie]

Let's try to repro 2 years later.

Comment 8

[Rob Wu [:robwu]]

Works for me in Fx 71.