1451664 - Tooltip for "Firefox" (Nightly) appears in places that don't contain the word.

Status: RESOLVED INVALID

(Firefox :: Settings UI, defect)

Description

[Oana Botisan, Desktop QA]

[Affected versions]:
- Firefox 59.0.2
- beta 60.0b10
- Nightly 61.0a1

[Affected platforms]:
- Windows 10 x64
- Ubuntu 16.04 x64
- macOS 10.13

[Steps to reproduce]:
1. Go to about:preferences.
2. In the search bar write "Firefox" ("Nightly" if you are working on Nightly)
3. Scroll down to "History".
4. Observe the tooltip.

[Expected result]:
- There isn't one, because when the doorhanger for "Firefox will... " doesn't contain the word "Firefox".

[Actual result]:
- There is a tooltip above the doorhanger for "Firefox will... " indicating that the  word "Firefox" is present in the doorhanger. 

[Regression range]:
- I don't think this is a regression, because I can reproduce the bug even on build from 2017-06-15 when the feature was first implemented. 

However I think that this is the reason why this bug appears. Before the build from 2017-06-15, after changing the "browser.preferences.search" to true, the issue didn't occur.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

This is actually working as designed, though potentially it could be made better (I don't have an idea how though).

What is happening is that for the History section, we have the dropdown: "Firefox will [Remember history v]"

In each of the three options, Firefox (the brandShortName) will appear in the text that is shown if the option is selected.
* When "Remember history" is selected the text that appears is: "{ -brand-short-name } will remember your browsing, download, form and search history."
* When "Never remember history" is selected the text that appears is: "{ -brand-short-name } will use the same settings as private browsing, and will not remember any history as you browse the Web."
* When "Use custom settings" is selected there are checkboxes and a Settings button that appears. One of the checkboxes says "Clear history when { -brand-short-name } closes". If the button is clicked we will show the string "When I quit &brandShortName;, it should automatically clear all"

So in each of the three cases the brandShortName is shown. This is why the dropdown has a yellow arrow next to each of the items to say that the search term is found within that item.

Searching for the brandShortName is an odd case because it appears somewhat randomly, but if the user is searching for "remember your browsing" then we want to highlight the dropdown item that will bring the user to that setting.