Closed Bug 1451710 Opened 2 years ago Closed 2 years ago

Remove dimple from macOS splitter

Categories

(Toolkit :: Themes, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: ntim, Assigned: manishkk)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The dimple was relevant for older versions of macOS where it matched the platform splitter, but this is no longer the case.

toolkit/themes/osx/global/splitter/dimple.png
https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/osx/global/splitter.css#15,43
https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/osx/global/jar.mn#86
Assignee: nobody → 1991manish.kumar
Attached patch Patch_Bug1451710Splinter Review
Please review.
Attachment #8965292 - Flags: review?(ntim.bugs)
Comment on attachment 8965292 [details] [diff] [review]
Patch_Bug1451710

Review of attachment 8965292 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8965292 - Flags: review?(ntim.bugs) → review?(dao+bmo)
Attachment #8965292 - Flags: review?(dao+bmo) → review+
Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/739f1e73cac0
Remove dimple from macOS splitter r=dao
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/739f1e73cac0
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.