Closed Bug 1451711 Opened 7 years ago Closed 7 years ago

Remove toolkit/themes/osx/global/toolbar/toolbar-separator.png

Categories

(Toolkit :: Themes, enhancement)

Product:
Toolkit
Component:
Themes
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: ntim, Assigned: manishkk)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

Patchv3_Bug1451711
1.85 KB, patch
dao
: review+
Details | Diff | Splinter Review
I don't think this styling is particularly relevant anymore. toolkit/themes/osx/global/toolbar/toolbar-separator.png https://dxr.mozilla.org/mozilla-central/search?q=toolbar-separator.png&redirect=false
Assignee: nobody → 1991manish.kumar
Attached patch Patch_Bug1451711 (obsolete) — — Splinter Review
Please review.
Attachment #8965294 - Flags: review?(ntim.bugs)
Comment on attachment 8965294 [details] [diff] [review] Patch_Bug1451711 Review of attachment 8965294 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8965294 - Flags: review?(ntim.bugs) → review?(dao+bmo)
Comment on attachment 8965294 [details] [diff] [review] Patch_Bug1451711 This would make toolbarseparator invisible, right? So at that point it wouldn't be a separator anymore, which seems nonsensical.
Attachment #8965294 - Flags: review?(dao+bmo) → review-
Manish, could you please use background: ThreeDShadow; to address dao's comment ?
actually, `background-color: ThreeDShadow;` would be slightly better.
Sorry, not clear to me? Where should I use `background-color: ThreeDShadow;` (In reply to Tim Nguyen :ntim from comment #4) > Manish, could you please use background: ThreeDShadow; to address dao's > comment ?
Flags: needinfo?(ntim.bugs)
(In reply to Manish Kumar from comment #6) > Sorry, not clear to me? Where should I use `background-color: ThreeDShadow;` Exactly where you removed `background: url("chrome://global/skin/toolbar/toolbar-separator.png") transparent repeat-y;`
Flags: needinfo?(ntim.bugs)
(In reply to Tim Nguyen :ntim from comment #0) > I don't think this styling is particularly relevant anymore. > Seems this file is gone. can you once check again? > toolkit/themes/osx/global/toolbar/toolbar-separator.png > > https://dxr.mozilla.org/mozilla-central/search?q=toolbar-separator. > png&redirect=false
Flags: needinfo?(ntim.bugs)
This line: https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/osx/global/toolbar.css#28 should be replaced with `background-color: ThreeDShadow;`
Flags: needinfo?(ntim.bugs)
Attached patch PatchV2_Bug1451711 (obsolete) — — Splinter Review
Attachment #8965294 - Attachment is obsolete: true
Attachment #8965326 - Flags: review?(ntim.bugs)
Comment on attachment 8965326 [details] [diff] [review] PatchV2_Bug1451711 This patch doesn't contain the file removal from your previous patch.
Attachment #8965326 - Flags: review?(ntim.bugs)
I started again by 'hg rollback' 'hg revert --all' 'hg pull' 'hg update --check' and 'toolbar-separator.png' not available on my system. That's why I am not able to apply patch on my system. same with this patch also- https://bugzilla.mozilla.org/show_bug.cgi?id=1451713
Flags: needinfo?(ntim.bugs)
You might want to ask for help on IRC: https://wiki.mozilla.org/IRC
Flags: needinfo?(ntim.bugs)
Please review
Attachment #8965326 - Attachment is obsolete: true
Attachment #8965462 - Flags: review?(ntim.bugs)
Attachment #8965462 - Flags: review?(ntim.bugs) → review?(dao+bmo)
Attachment #8965462 - Flags: review?(dao+bmo) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/40d45d638a07 Remove toolkit/themes/osx/global/toolbar/toolbar-separator.png. r=Dao
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/40d45d638a07
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Depends on: 1452303
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: