Remove toolkit/themes/osx/global/toolbar/toolbar-separator.png

RESOLVED FIXED in Firefox 61

Status

()

enhancement
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: ntim, Assigned: manishkk)

Tracking

(Blocks 1 bug)

unspecified
mozilla61
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Reporter

Description

a year ago
I don't think this styling is particularly relevant anymore.

toolkit/themes/osx/global/toolbar/toolbar-separator.png

https://dxr.mozilla.org/mozilla-central/search?q=toolbar-separator.png&redirect=false
Assignee

Updated

a year ago
Assignee: nobody → 1991manish.kumar
Assignee

Comment 1

a year ago
Posted patch Patch_Bug1451711 (obsolete) — Splinter Review
Please review.
Attachment #8965294 - Flags: review?(ntim.bugs)
Reporter

Comment 2

a year ago
Comment on attachment 8965294 [details] [diff] [review]
Patch_Bug1451711

Review of attachment 8965294 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8965294 - Flags: review?(ntim.bugs) → review?(dao+bmo)
Comment on attachment 8965294 [details] [diff] [review]
Patch_Bug1451711

This would make toolbarseparator invisible, right? So at that point it wouldn't be a separator anymore, which seems nonsensical.
Attachment #8965294 - Flags: review?(dao+bmo) → review-
Reporter

Comment 4

a year ago
Manish, could you please use background: ThreeDShadow; to address dao's comment ?
Reporter

Comment 5

a year ago
actually, `background-color: ThreeDShadow;` would be slightly better.
Assignee

Comment 6

a year ago
Sorry, not clear to me? Where should I use `background-color: ThreeDShadow;`


(In reply to Tim Nguyen :ntim from comment #4)
> Manish, could you please use background: ThreeDShadow; to address dao's
> comment ?
Flags: needinfo?(ntim.bugs)
Reporter

Comment 7

a year ago
(In reply to Manish Kumar from comment #6)
> Sorry, not clear to me? Where should I use `background-color: ThreeDShadow;`

Exactly where you removed `background: url("chrome://global/skin/toolbar/toolbar-separator.png") transparent repeat-y;`
Flags: needinfo?(ntim.bugs)
Assignee

Comment 8

a year ago
(In reply to Tim Nguyen :ntim from comment #0)
> I don't think this styling is particularly relevant anymore.
> 


Seems this file is gone. can you once check again?
> toolkit/themes/osx/global/toolbar/toolbar-separator.png



> 
> https://dxr.mozilla.org/mozilla-central/search?q=toolbar-separator.
> png&redirect=false
Flags: needinfo?(ntim.bugs)
Reporter

Comment 9

a year ago
This line: https://dxr.mozilla.org/mozilla-central/source/toolkit/themes/osx/global/toolbar.css#28

should be replaced with `background-color: ThreeDShadow;`
Flags: needinfo?(ntim.bugs)
Assignee

Comment 10

a year ago
Posted patch PatchV2_Bug1451711 (obsolete) — Splinter Review
Attachment #8965294 - Attachment is obsolete: true
Attachment #8965326 - Flags: review?(ntim.bugs)
Reporter

Comment 11

a year ago
Comment on attachment 8965326 [details] [diff] [review]
PatchV2_Bug1451711

This patch doesn't contain the file removal from your previous patch.
Reporter

Updated

a year ago
Attachment #8965326 - Flags: review?(ntim.bugs)
Assignee

Comment 12

a year ago
I started again by

'hg rollback'
'hg revert --all'
'hg pull'
'hg update --check'

and 'toolbar-separator.png' not available on my system. That's why I am not able to apply patch on my system.
same with this patch also- https://bugzilla.mozilla.org/show_bug.cgi?id=1451713
Flags: needinfo?(ntim.bugs)
Reporter

Comment 13

a year ago
You might want to ask for help on IRC: https://wiki.mozilla.org/IRC
Flags: needinfo?(ntim.bugs)
Assignee

Comment 14

a year ago
Please review
Attachment #8965326 - Attachment is obsolete: true
Attachment #8965462 - Flags: review?(ntim.bugs)
Reporter

Updated

a year ago
Attachment #8965462 - Flags: review?(ntim.bugs) → review?(dao+bmo)
Attachment #8965462 - Flags: review?(dao+bmo) → review+

Comment 15

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/40d45d638a07
Remove toolkit/themes/osx/global/toolbar/toolbar-separator.png. r=Dao
Keywords: checkin-needed

Comment 16

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/40d45d638a07
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Reporter

Updated

a year ago
Depends on: 1452303
You need to log in before you can comment on or make changes to this bug.