Open Bug 1451716 Opened 6 years ago Updated 2 years ago

No scrollElementIntoView on Touch enabled Win10 devices.

Categories

(Firefox :: General, defect, P3)

59 Branch
defect

Tracking

()

Tracking Status
firefox59 --- affected
firefox60 --- affected
firefox61 --- affected

People

(Reporter: tunepunk, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [tabletmode])

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.162 Safari/537.36

Steps to reproduce:

1. Open firefox on touch/pen enabled win10 device.
2. Browse to any page with text input boxes such as a comment section.
3. Make sure the input box is on the lower part of the screen.
4. Tap the input box with pen or touch.


Actual results:

Page did not shift and now the on screen keyboard covers the input field so you can't see what you're typing.


Expected results:

Expected behaviour should be exactly like firefox mobile version, when using a pen/touch enabled win 10 device. Tapping input fields should shift the page so that on screen keyboard does not cover the input field you're trying to enter text into.
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0 (20180323154952)

I have tested this issue on Surface Pro with Win10 using latest Nightly and Fx Release builds. I was able to reproduce the mentioned behavior. When the input box is in the lower part of the screen and virtual keyboard is displayed, it cover the input field box. It would be nice if the page was shifted as on mobile device to not cover the input field.

I think the correct component would be Core::Widget: Gtk. Please change if this is not the right component.
Component: Untriaged → Widget: Gtk
Product: Firefox → Core
Status: UNCONFIRMED → NEW
Ever confirmed: true
Might there be a flag in about:config that enables or disables this feature? If mobile has it, then it might just not be activated for desktop?
Summary: No page shift when tapping input fields → No scrollElementIntoView on Touch enabled Win10 devices.
scrollElementIntoView

or possibly

ensureElementIsVisible

needs to be enabled for Touch enabled Win 10 devices, when on screen keyboard is opened.
Can anyone confirm this? It's really frustrating that the touch keyboard is blocking the input field i'm supposed to type in.

Win10 desktop devices using on screen touch keyboard also needs to shift elements in to view when using touch.
Flags: needinfo?(jmathies)
I can confirm, we don't handle this internally.
Component: Widget: Gtk → Tabbed Browser
Flags: needinfo?(jmathies)
Product: Core → Firefox
Whiteboard: [tabletmode]
Blocks: tabletmode
Component: Tabbed Browser → General
:snorp, can we reuse the mobile code for this in some way? What happens there?
Flags: needinfo?(snorp)
GeckoView and Fennec both send an event to Gecko when the keyboard is shown. You can see what we do in response to that here[1]. Most of this can probably be factored out if we need something similar on desktop.

[1] https://searchfox.org/mozilla-central/source/mobile/android/chrome/geckoview/GeckoViewContent.js#114
Flags: needinfo?(snorp)
Taking a stab at a priority to move this out of the triage list. Adjust as necessary.
Priority: -- → P3
Noticed that latest chrome for desktop has this functionality now. Edge used to have it but most have got lost in some release. Anyway very handy when using surface pro type win10 tablets on the go, when no keyboard is connected.
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.