Application panel: add tracking parameters to outgoing links in application panel

RESOLVED FIXED in Firefox 62

Status

enhancement
P3
normal
RESOLVED FIXED
a year ago
11 months ago

People

(Reporter: jdescottes, Assigned: ladybenko)

Tracking

(Blocks 1 bug)

unspecified
Firefox 62
Dependency tree / graph

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment)

When no service workers are registered, the application panel displays a link to MDN: https://developer.mozilla.org/docs/Web/API/Service_Worker_API/Using_Service_Workers

We need to define which GA parameters we should use here and add them to the URL.
Assignee

Updated

a year ago
Assignee: nobody → balbeza
Comment hidden (mozreview-request)
Assignee

Updated

a year ago
Attachment #8972858 - Flags: review?(hkirschner)
Reporter

Comment 2

a year ago
mozreview-review
Comment on attachment 8972858 [details]
Bug 1451737 - add GA parameters to outgoing links in application panel.

https://reviewboard.mozilla.org/r/241166/#review247324

Looks good to me, thanks for the patch. Should we state utm_campaign=blank or simply omit it? 
I rely on Harald's review to clarify this.

::: npm-shrinkwrap.json:175
(Diff revision 1)
>              "has-flag": "3.0.0"
>            }
>          }
>        }
>      },
>      "chardet": {

Not sure how this got updated (maybe https://bugzilla.mozilla.org/show_bug.cgi?id=1456403) but we should remove it from the patch
Attachment #8972858 - Flags: review?(jdescottes) → review+

Comment 3

a year ago
mozreview-review
Comment on attachment 8972858 [details]
Bug 1451737 - add GA parameters to outgoing links in application panel.

https://reviewboard.mozilla.org/r/241166/#review247434

::: devtools/client/application/src/components/WorkerListEmpty.js:11
(Diff revision 1)
>  
>  const PropTypes = require("devtools/client/shared/vendor/react-prop-types");
>  const { Component } = require("devtools/client/shared/vendor/react");
>  const { a, div, li, ul } = require("devtools/client/shared/vendor/react-dom-factories");
> -const DOC_URL = "https://developer.mozilla.org/docs/Web/API/Service_Worker_API/Using_Service_Workers";
> -
> +const DOC_URL = "https://developer.mozilla.org/docs/Web/API/Service_Worker_API/Using_Service_Workers" +
> +  "?utm_source=devtools&utm_medium=sw-panel&utm_campaign=blank";

To follow the same format for other links added recently: medium to "sw-panel-blank" (for more specificity) and remove campaign
Attachment #8972858 - Flags: review?(hkirschner) → review-
Comment hidden (mozreview-request)
Mass move to the new application panel component.
Component: Developer Tools → Developer Tools: Application Panel
Reporter

Updated

a year ago
Status: NEW → ASSIGNED
Comment on attachment 8972858 [details]
Bug 1451737 - add GA parameters to outgoing links in application panel.

Can you review the new patch?
Attachment #8972858 - Flags: review?(hkirschner)

Comment 7

a year ago
mozreview-review
Comment on attachment 8972858 [details]
Bug 1451737 - add GA parameters to outgoing links in application panel.

https://reviewboard.mozilla.org/r/241166/#review248310

LGTM
Attachment #8972858 - Flags: review?(hkirschner) → review+
Assignee

Updated

a year ago
Keywords: checkin-needed

Comment 8

a year ago
Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/858f248f4714
add GA parameters to outgoing links in application panel. r=Harald,jdescottes
Keywords: checkin-needed

Comment 9

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/858f248f4714
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62

Updated

11 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.