1451737 - Application panel: add tracking parameters to outgoing links in application panel

Status: RESOLVED FIXED

(DevTools :: Application Panel, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

When no service workers are registered, the application panel displays a link to MDN: https://developer.mozilla.org/docs/Web/API/Service_Worker_API/Using_Service_Workers

We need to define which GA parameters we should use here and add them to the URL.

Comment 1

[Belén [:ladybenko]]

Attachment: Bug 1451737 - add GA parameters to outgoing links in application panel.

Review commit: https://reviewboard.mozilla.org/r/241166/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/241166/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8972858 [details]
Bug 1451737 - add GA parameters to outgoing links in application panel.

https://reviewboard.mozilla.org/r/241166/#review247324

Looks good to me, thanks for the patch. Should we state utm_campaign=blank or simply omit it? 
I rely on Harald's review to clarify this.

::: npm-shrinkwrap.json:175
(Diff revision 1)
>              "has-flag": "3.0.0"
>            }
>          }
>        }
>      },
>      "chardet": {

Not sure how this got updated (maybe https://bugzilla.mozilla.org/show_bug.cgi?id=1456403) but we should remove it from the patch

Comment 3

[:Harald Kirschner :digitarald]

Comment on attachment 8972858 [details]
Bug 1451737 - add GA parameters to outgoing links in application panel.

https://reviewboard.mozilla.org/r/241166/#review247434

::: devtools/client/application/src/components/WorkerListEmpty.js:11
(Diff revision 1)
>  
>  const PropTypes = require("devtools/client/shared/vendor/react-prop-types");
>  const { Component } = require("devtools/client/shared/vendor/react");
>  const { a, div, li, ul } = require("devtools/client/shared/vendor/react-dom-factories");
> -const DOC_URL = "https://developer.mozilla.org/docs/Web/API/Service_Worker_API/Using_Service_Workers";
> -
> +const DOC_URL = "https://developer.mozilla.org/docs/Web/API/Service_Worker_API/Using_Service_Workers" +
> +  "?utm_source=devtools&utm_medium=sw-panel&utm_campaign=blank";

To follow the same format for other links added recently: medium to "sw-panel-blank" (for more specificity) and remove campaign

Comment 4

[Belén [:ladybenko]]

Comment on attachment 8972858 [details]
Bug 1451737 - add GA parameters to outgoing links in application panel.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/241166/diff/1-2/

Comment 5

[Patrick Brosset <:pbro>]

Mass move to the new application panel component.

Comment 6

[Julian Descottes [:jdescottes]]

Comment on attachment 8972858 [details]
Bug 1451737 - add GA parameters to outgoing links in application panel.

Can you review the new patch?

Comment 7

[:Harald Kirschner :digitarald]

Comment on attachment 8972858 [details]
Bug 1451737 - add GA parameters to outgoing links in application panel.

https://reviewboard.mozilla.org/r/241166/#review248310

LGTM

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/858f248f4714
add GA parameters to outgoing links in application panel. r=Harald,jdescottes

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/858f248f4714