1451744 - 6.4 - 6.4% compiler_metrics num_static_constructors (linux32, linux64) regression on push b92f856e15a80efb562203ca00169c06fb1f4ae4 (Thu Apr 5 2018)

Status: VERIFIED FIXED

(Core :: General, defect)

Description

[Ionuț Goldan [:igoldan]]

We have detected a build metrics regression from push:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=b92f856e15a80efb562203ca00169c06fb1f4ae4

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

  6%  compiler_metrics num_static_constructors linux32 pgo      125.00 -> 133.00
  6%  compiler_metrics num_static_constructors linux64 pgo      125.00 -> 133.00
  6%  compiler_metrics num_static_constructors linux32 opt      125.00 -> 133.00
  6%  compiler_metrics num_static_constructors linux64 opt      125.00 -> 133.00


You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=12526

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Build_Metrics

Comment 1

[Ionuț Goldan [:igoldan]]

:njn Can we reduce these numbers or is this something we have to accept?

Comment 2

[Nicholas Nethercote [inactive]]

Ugh, that's annoying.

These patches are a prerequisite for bug 1449787, but that won't be doable for a while because MSVC has a bug that's blocking them. In the meantime, I think the appropriate thing to do is back them out.

Ionuț, would you mind doing that? Thank you.

Comment 3

[Ionuț Goldan [:igoldan]]

(In reply to Nicholas Nethercote [:njn] from comment #2)
> Ugh, that's annoying.
> 
> These patches are a prerequisite for bug 1449787, but that won't be doable
> for a while because MSVC has a bug that's blocking them. In the meantime, I
> think the appropriate thing to do is back them out.
> 
> Ionuț, would you mind doing that? Thank you.

Sure, I've just requested the backout.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Can you confirm that the numbers went back to where they were before post-backout?

Comment 5

[Ionuț Goldan [:igoldan]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #4)
> Can you confirm that the numbers went back to where they were before
> post-backout?

Yes, the backout resolved the issues.

== Change summary for alert #12737 (as of Mon, 16 Apr 2018 08:12:23 GMT) ==

Improvements:

  6%  compiler_metrics num_static_constructors linux64 opt      133.75 -> 126.00
  6%  compiler_metrics num_static_constructors linux32 opt      133.75 -> 126.00
  6%  compiler_metrics num_static_constructors linux64 pgo      133.75 -> 126.00
  6%  compiler_metrics num_static_constructors linux32 pgo      133.71 -> 126.00

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=12737

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Thanks for confirming.