Closed Bug 1451823 Opened 2 years ago Closed 2 years ago

Support ping, rel, referrerPolicy, relList, hreflang, type and text properties on SVG <a> elements

Categories

(Core :: SVG, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: longsonr, Assigned: longsonr)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → longsonr
Attachment #8965403 - Attachment is patch: true
Attachment #8965403 - Attachment is obsolete: true
Comment on attachment 8965458 [details] [diff] [review]
implement and fix test

Passes the tests in bug 1450824 except for 1 expected failure and 1 test bug (https://github.com/w3c/web-platform-tests/pull/10275)

The attributes are DOMString based on the resolution in https://github.com/w3c/svgwg/issues/315 and the tests from https://github.com/w3c/web-platform-tests/pull/10275 expect that too.

Checkin comment:

Bug 1451823 - support ping, rel, referrerPolicy, relList, hreflang, type and text on SVG a elements r=mystor
Attachment #8965458 - Flags: review?(nika)
Comment on attachment 8965458 [details] [diff] [review]
implement and fix test

Review of attachment 8965458 [details] [diff] [review]:
-----------------------------------------------------------------

Please make sure you send a Request to Implement & Ship to dev-platform before landing this :-)

::: dom/svg/SVGAElement.cpp
@@ +34,5 @@
>    { &nsGkAtoms::target, kNameSpaceID_None, true }
>  };
>  
> +// static
> +const DOMTokenListSupportedToken SVGAElement::sSupportedRelValues[] = {

It'd be nice to merge this with the HTMLAnchorElement::sSupportedRelValues, but that may not be worth doing in this patch.
Attachment #8965458 - Flags: review?(nika) → review+
Pushed by longsonr@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1d4a3e6c77a
support ping, rel, referrerPolicy, relList, hreflang, type and text on SVG a elements r=mystor
Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/10473 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
https://hg.mozilla.org/mozilla-central/rev/a1d4a3e6c77a
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.