1451853 - Include the Firefox build id in the profiler's meta information

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement)

Description

[Markus Stange [:mstange]]

For https://github.com/devtools-html/perf.html/issues/603

This can be obtained from nsXULAppInfo::GetAppBuildID().

Comment 1

[Markus Stange [:mstange]]

Additionally we may also want the source URL, e.g. https://hg.mozilla.org/mozilla-central/rev/110f32790d38a258cab722064aae40736478ef51 , which is displayed on about:buildconfig

It looks like the source URL is stored in the MOZ_SOURCE_URL #define.

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Bug 1451853 - Include Firefox build id and source URL in profiler meta information.

Review commit: https://reviewboard.mozilla.org/r/243270/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243270/

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

Oops, the test is failing. I'll investigate.

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8974883 [details]
Bug 1451853 - Include Firefox build id and source URL in profiler meta information.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/243270/diff/1-2/

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Unfortunately this test can't work: the source URL is only present in MOZILLA_OFFICIAL builds and appBuildID can only be retrieved from the main thread. I could make broader changes to the test to accommodate these requirements (#ifdef sourceURL and assert appBuildID outside JSONOutputCheck), but it doesn't seem worthwhile for such a simple change.

Comment 6

[Markus Stange [:mstange]]

Comment on attachment 8974883 [details]
Bug 1451853 - Include Firefox build id and source URL in profiler meta information.

https://reviewboard.mozilla.org/r/243270/#review249340

Thanks!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ae61c08d9f6
Include Firefox build id and source URL in profiler meta information. r=mstange

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/2ae61c08d9f6