Closed Bug 1451853 Opened 3 years ago Closed 3 years ago

Include the Firefox build id in the profiler's meta information

Categories

(Core :: Gecko Profiler, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox61 --- wontfix
firefox62 --- fixed

People

(Reporter: mstange, Assigned: past)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file)

For https://github.com/devtools-html/perf.html/issues/603

This can be obtained from nsXULAppInfo::GetAppBuildID().
Additionally we may also want the source URL, e.g. https://hg.mozilla.org/mozilla-central/rev/110f32790d38a258cab722064aae40736478ef51 , which is displayed on about:buildconfig

It looks like the source URL is stored in the MOZ_SOURCE_URL #define.
Assignee: nobody → past
Status: NEW → ASSIGNED
Oops, the test is failing. I'll investigate.
Unfortunately this test can't work: the source URL is only present in MOZILLA_OFFICIAL builds and appBuildID can only be retrieved from the main thread. I could make broader changes to the test to accommodate these requirements (#ifdef sourceURL and assert appBuildID outside JSONOutputCheck), but it doesn't seem worthwhile for such a simple change.
Comment on attachment 8974883 [details]
Bug 1451853 - Include Firefox build id and source URL in profiler meta information.

https://reviewboard.mozilla.org/r/243270/#review249340

Thanks!
Attachment #8974883 - Flags: review?(mstange) → review+
Pushed by pastithas@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ae61c08d9f6
Include Firefox build id and source URL in profiler meta information. r=mstange
https://hg.mozilla.org/mozilla-central/rev/2ae61c08d9f6
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.