Closed Bug 1451944 Opened 5 years ago Closed 5 years ago
Keyboard shortcut hint is too dark and hard to read with dark theme
Keyboard shortcut hints (like CTRL+N) in the hamburg menu are too dark and almost impossible to read when the dark theme is enabled. See screenshot
The shortcut hint uses the color "GrayText" which may be different depending on the platform theme. The solution to this bug is to use `opacity: 0.5` instead of `color: GrayText` when the popup is styled.
Assignee: nobody → ablayelyfondou
Status: NEW → ASSIGNED
Comment on attachment 8967255 [details] [diff] [review] Use 'opacity: 0.5' instead of 'color: GrayText' for keyboard shortcut hint in hamburger menu Thanks, I tested this out, looks good!
Attachment #8967255 - Flags: review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/e4a176915c3c Use 'opacity: 0.5' instead of 'color: GrayText' for keyboard shortcut hint in hamburger menu. r=jaws
I have reproduced this bug on Nightly according to (2018-04-05) Fixing bug is verified on Latest Nightly-- Build ID 20180425220031 User Agent Mozilla/5.0 (Windows NT 10.0; rv:61.0) Gecko/20100101 Firefox/61.0 Tested OS-- Windows7 32bit
QA Whiteboard: [bugday-20180425]
(In reply to Saheda Reza [:Antora] from comment #6) > I have reproduced this bug on Nightly according to (2018-04-05) > > Fixing bug is verified on Latest Nightly-- > Build ID 20180425220031 > User Agent Mozilla/5.0 (Windows NT 10.0; rv:61.0) Gecko/20100101 > Firefox/61.0 > > Tested OS-- Windows7 32bit Thanks for verifying this in 61. Marking as verified.
You need to log in before you can comment on or make changes to this bug.