1451944 - Keyboard shortcut hint is too dark and hard to read with dark theme

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Tom Schuster [:evilpie]]

Attachment: Screenshot

Keyboard shortcut hints (like CTRL+N) in the hamburg menu are too dark and almost impossible to read when the dark theme is enabled. See screenshot

Comment 1

[Tim Nguyen :ntim]

The shortcut hint uses the color "GrayText" which may be different depending on the platform theme.

The solution to this bug is to use `opacity: 0.5` instead of `color: GrayText` when the popup is styled.

Comment 2

[Abdoulaye O. LY]

Attachment: Use 'opacity: 0.5' instead of 'color: GrayText' for keyboard shortcut hint in hamburger menu

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8967255 [details] [diff] [review]
Use 'opacity: 0.5' instead of 'color: GrayText' for keyboard shortcut hint in hamburger menu

Thanks, I tested this out, looks good!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e4a176915c3c
Use 'opacity: 0.5' instead of 'color: GrayText' for keyboard shortcut hint in hamburger menu. r=jaws

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/e4a176915c3c

Comment 6

[Saheda Reza [:Antora]]

I have reproduced this bug on Nightly according to (2018-04-05)

Fixing bug is verified on Latest Nightly--
Build ID    20180425220031
User Agent  Mozilla/5.0 (Windows NT 10.0; rv:61.0) Gecko/20100101 Firefox/61.0

Tested OS-- Windows7 32bit

Comment 7

[Bogdan Maris [:bogdan_maris], Release Desktop QA]

(In reply to Saheda Reza [:Antora] from comment #6)
> I have reproduced this bug on Nightly according to (2018-04-05)
> 
> Fixing bug is verified on Latest Nightly--
> Build ID    20180425220031
> User Agent  Mozilla/5.0 (Windows NT 10.0; rv:61.0) Gecko/20100101
> Firefox/61.0
> 
> Tested OS-- Windows7 32bit

Thanks for verifying this in 61. Marking as verified.