Closed Bug 1451944 Opened 2 years ago Closed 2 years ago

Keyboard shortcut hint is too dark and hard to read with dark theme

Categories

(Firefox :: Theme, defect, P1)

Product:
Firefox
Component:
Theme
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 61
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox59 --- unaffected
firefox60 --- unaffected
firefox61 --- verified

People

(Reporter: evilpie, Assigned: ablayelyfondou, Mentored)

References

Details

(Keywords: regression)

Attachments

(2 files)

Screenshot
20.62 KB, image/png
Details
Use 'opacity: 0.5' instead of 'color: GrayText' for keyboard shortcut hint in hamburger menu
825 bytes, patch
jaws
: review+
Details | Diff | Splinter Review
Attached image Screenshot — 
Keyboard shortcut hints (like CTRL+N) in the hamburg menu are too dark and almost impossible to read when the dark theme is enabled. See screenshot
Blocks: 1408121
The shortcut hint uses the color "GrayText" which may be different depending on the platform theme.

The solution to this bug is to use `opacity: 0.5` instead of `color: GrayText` when the popup is styled.
Mentor: ntim.bugs
status-firefox60: --- → unaffected
status-firefox61: --- → affected
Keywords: regression
Priority: -- → P1
Assignee: nobody → ablayelyfondou
Status: NEW → ASSIGNED
Flags: needinfo?(ntim.bugs)
Flags: needinfo?(jaws)
Comment on attachment 8967255 [details] [diff] [review]
Use 'opacity: 0.5' instead of 'color: GrayText' for keyboard shortcut hint in hamburger menu

Thanks, I tested this out, looks good!
Flags: needinfo?(ntim.bugs)
Flags: needinfo?(jaws)
Attachment #8967255 - Flags: review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e4a176915c3c
Use 'opacity: 0.5' instead of 'color: GrayText' for keyboard shortcut hint in hamburger menu. r=jaws
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e4a176915c3c
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox61: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
I have reproduced this bug on Nightly according to (2018-04-05)

Fixing bug is verified on Latest Nightly--
Build ID    20180425220031
User Agent  Mozilla/5.0 (Windows NT 10.0; rv:61.0) Gecko/20100101 Firefox/61.0

Tested OS-- Windows7 32bit
QA Whiteboard: [bugday-20180425]
(In reply to Saheda Reza [:Antora] from comment #6)
> I have reproduced this bug on Nightly according to (2018-04-05)
> 
> Fixing bug is verified on Latest Nightly--
> Build ID    20180425220031
> User Agent  Mozilla/5.0 (Windows NT 10.0; rv:61.0) Gecko/20100101
> Firefox/61.0
> 
> Tested OS-- Windows7 32bit

Thanks for verifying this in 61. Marking as verified.
Status: RESOLVED → VERIFIED
status-firefox61: fixed → verified
You need to log in before you can comment on or make changes to this bug.