Closed
Bug 1451944
Opened 4 years ago
Closed 4 years ago
Keyboard shortcut hint is too dark and hard to read with dark theme
Categories
(Firefox :: Theme, defect, P1)
Firefox
Theme
Tracking
()
VERIFIED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox59 | --- | unaffected |
firefox60 | --- | unaffected |
firefox61 | --- | verified |
People
(Reporter: evilpie, Assigned: ablayelyfondou, Mentored)
References
Details
(Keywords: regression)
Attachments
(2 files)
20.62 KB,
image/png
|
Details | |
825 bytes,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
Keyboard shortcut hints (like CTRL+N) in the hamburg menu are too dark and almost impossible to read when the dark theme is enabled. See screenshot
Comment 1•4 years ago
|
||
The shortcut hint uses the color "GrayText" which may be different depending on the platform theme. The solution to this bug is to use `opacity: 0.5` instead of `color: GrayText` when the popup is styled.
Mentor: ntim.bugs
Updated•4 years ago
|
status-firefox60:
--- → unaffected
status-firefox61:
--- → affected
Keywords: regression
Priority: -- → P1
Updated•4 years ago
|
Assignee: nobody → ablayelyfondou
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Flags: needinfo?(ntim.bugs)
Flags: needinfo?(jaws)
Comment 3•4 years ago
|
||
Comment on attachment 8967255 [details] [diff] [review] Use 'opacity: 0.5' instead of 'color: GrayText' for keyboard shortcut hint in hamburger menu Thanks, I tested this out, looks good!
Updated•4 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e4a176915c3c Use 'opacity: 0.5' instead of 'color: GrayText' for keyboard shortcut hint in hamburger menu. r=jaws
Keywords: checkin-needed
Comment 5•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e4a176915c3c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Updated•4 years ago
|
status-firefox59:
--- → unaffected
status-firefox-esr52:
--- → unaffected
Comment 6•4 years ago
|
||
I have reproduced this bug on Nightly according to (2018-04-05) Fixing bug is verified on Latest Nightly-- Build ID 20180425220031 User Agent Mozilla/5.0 (Windows NT 10.0; rv:61.0) Gecko/20100101 Firefox/61.0 Tested OS-- Windows7 32bit
QA Whiteboard: [bugday-20180425]
Comment 7•4 years ago
|
||
(In reply to Saheda Reza [:Antora] from comment #6) > I have reproduced this bug on Nightly according to (2018-04-05) > > Fixing bug is verified on Latest Nightly-- > Build ID 20180425220031 > User Agent Mozilla/5.0 (Windows NT 10.0; rv:61.0) Gecko/20100101 > Firefox/61.0 > > Tested OS-- Windows7 32bit Thanks for verifying this in 61. Marking as verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•