1451962 - Refactor nightly target task functions.

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Tom Prince [:tomprince]]

The different nightly platform target task definitions are almost identical. Refactor them to get rid of the accidental differences.

Comment 1

[Phabricator Automation]

Attachment: Bug 1451962: Rename `filter_on_nightly` to `filter_out_nightly` in `taskgraph.target_tasks`; r?dustin

Make it clear that the function filters out nightly tasks.

Comment 2

[Phabricator Automation]

Attachment: Bug 1451962; Refactor nightly target task functionss; r?dustin

There is slight random variation in the functions. Refactor them so that they
behave the same.

Comment 3

[Phabricator Automation]

Comment on attachment 8965733 [details]
Bug 1451962: Rename `filter_on_nightly` to `filter_out_nightly` in `taskgraph.target_tasks`; r?dustin

Dustin J. Mitchell [:dustin] pronoun: he has approved the revision.

https://phabricator.services.mozilla.com/D861

Comment 4

[Phabricator Automation]

Comment on attachment 8965734 [details]
Bug 1451962; Refactor nightly target task functionss; r?dustin

Dustin J. Mitchell [:dustin] pronoun: he has approved the revision.

https://phabricator.services.mozilla.com/D862

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0cb209d9f3f
Rename `filter_on_nightly` to `filter_out_nightly` in `taskgraph.target_tasks`; r=dustin
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c1a171c57ef
; Refactor nightly target task functionss; r=dustin

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/e0cb209d9f3f
https://hg.mozilla.org/mozilla-central/rev/0c1a171c57ef