Closed Bug 1451962 Opened 4 years ago Closed 4 years ago

Refactor nightly target task functions.

Categories

(Firefox Build System :: Task Configuration, task)

Product:
Firefox Build System
Component:
Task Configuration
Version:
3 Branch
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(firefox61 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: tomprince, Assigned: tomprince)

Details

Attachments

(2 files)

Bug 1451962: Rename `filter_on_nightly` to `filter_out_nightly` in `taskgraph.target_tasks`; r?dustin
45 bytes, text/x-phabricator-request
dustin
: review+
Details | Review
Bug 1451962; Refactor nightly target task functionss; r?dustin
45 bytes, text/x-phabricator-request
dustin
: review+
Details | Review 
The different nightly platform target task definitions are almost identical. Refactor them to get rid of the accidental differences.
Make it clear that the function filters out nightly tasks.
There is slight random variation in the functions. Refactor them so that they
behave the same.
Attachment #8965733 - Flags: review?(dustin)
Attachment #8965734 - Flags: review?(dustin)
Comment on attachment 8965733 [details]
Bug 1451962: Rename `filter_on_nightly` to `filter_out_nightly` in `taskgraph.target_tasks`; r?dustin

Dustin J. Mitchell [:dustin] pronoun: he has approved the revision.

https://phabricator.services.mozilla.com/D861
Attachment #8965733 - Flags: review+
Comment on attachment 8965734 [details]
Bug 1451962; Refactor nightly target task functionss; r?dustin

Dustin J. Mitchell [:dustin] pronoun: he has approved the revision.

https://phabricator.services.mozilla.com/D862
Attachment #8965734 - Flags: review+
Attachment #8965733 - Flags: review?(dustin)
Attachment #8965734 - Flags: review?(dustin)
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0cb209d9f3f
Rename `filter_on_nightly` to `filter_out_nightly` in `taskgraph.target_tasks`; r=dustin
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c1a171c57ef
; Refactor nightly target task functionss; r=dustin
https://hg.mozilla.org/mozilla-central/rev/e0cb209d9f3f
https://hg.mozilla.org/mozilla-central/rev/0c1a171c57ef
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.