Closed
Bug 1451962
Opened 7 years ago
Closed 7 years ago
Refactor nightly target task functions.
Categories
(Firefox Build System :: Task Configuration, task)
Tracking
(firefox61 fixed)
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: tomprince, Assigned: tomprince)
Details
Attachments
(2 files)
The different nightly platform target task definitions are almost identical. Refactor them to get rid of the accidental differences.
Comment 1•7 years ago
|
||
Make it clear that the function filters out nightly tasks.
Comment 2•7 years ago
|
||
There is slight random variation in the functions. Refactor them so that they
behave the same.
Assignee | ||
Updated•7 years ago
|
Attachment #8965733 -
Flags: review?(dustin)
Assignee | ||
Updated•7 years ago
|
Attachment #8965734 -
Flags: review?(dustin)
Comment 3•7 years ago
|
||
Comment on attachment 8965733 [details]
Bug 1451962: Rename `filter_on_nightly` to `filter_out_nightly` in `taskgraph.target_tasks`; r?dustin
Dustin J. Mitchell [:dustin] pronoun: he has approved the revision.
https://phabricator.services.mozilla.com/D861
Attachment #8965733 -
Flags: review+
Comment 4•7 years ago
|
||
Comment on attachment 8965734 [details]
Bug 1451962; Refactor nightly target task functionss; r?dustin
Dustin J. Mitchell [:dustin] pronoun: he has approved the revision.
https://phabricator.services.mozilla.com/D862
Attachment #8965734 -
Flags: review+
Updated•7 years ago
|
Attachment #8965733 -
Flags: review?(dustin)
Updated•7 years ago
|
Attachment #8965734 -
Flags: review?(dustin)
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0cb209d9f3f
Rename `filter_on_nightly` to `filter_out_nightly` in `taskgraph.target_tasks`; r=dustin
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c1a171c57ef
; Refactor nightly target task functionss; r=dustin
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e0cb209d9f3f
https://hg.mozilla.org/mozilla-central/rev/0c1a171c57ef
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•7 years ago
|
Version: Version 3 → 3 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•