1451991 - Devtools: Localstorage didn't list item whose key names "key"

Status: RESOLVED FIXED

(DevTools :: Storage Inspector, defect)

Description

[Liqueur Librazy]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20100101

Steps to reproduce:

Run 
localStorage.setItem("key", "value")
localStorage.setItem("key2", "value")
in devtools' console and switch to storage tab and inspect localStoage list.
Same to sessionStorage


Actual results:

Only item "key2" is listed.


Expected results:

Both items "key" and "key2" are listed.

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

This looks like some kind of platform issue:

Run 
localStorage.setItem("key", "value")
localStorage.setItem("key2", "value")
Object.keys(localStorage) // Only lists key2

This only appears to happen with local and session storage as other objects list "key".

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

So the issue is that we use Object.keys to iterate through these storage types and "key" is a method on the prototype.

localStorage.setItem("setItem", "value3") would cause a similar issue.

So we need to find a way to get all keys.

Comment 3

[Liqueur Librazy]

for ( var i = 0, len = localStorage.length; i < len; ++i ) {
  console.log( localStorage.key( i ) );
}

Dirty but works.

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1451991 - Devtools: Localstorage didn't list item whose key names "key"

Review commit: https://reviewboard.mozilla.org/r/236812/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/236812/

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8968136 [details]
Bug 1451991 - Devtools: Localstorage didn't list item whose key names "key"

https://reviewboard.mozilla.org/r/236812/#review242562

Looks good to me, thanks Mike

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/865e7a04728a
Devtools: Localstorage didn't list item whose key names "key" r=nchevobbe

Comment 7

[Cosmin Sabou [:CosminS]]

Backed out for mochitest devtools failures on browser_storage_basic_usercontextid_1.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&fromchange=865e7a04728ade4af81bc6d2899021f19f01b766&tochange=ab04b1ca218d7a0ce370ca9f2fd2028fee17567a&filter-searchStr=mochitest%20devtools&selectedJob=174054800

Failure log: 
https://treeherder.mozilla.org/logviewer.html#?job_id=174057723&repo=autoland&lineNumber=4382
https://treeherder.mozilla.org/logviewer.html#?job_id=174057308&repo=autoland&lineNumber=2433

Backout link: https://hg.mozilla.org/integration/autoland/rev/4a8db7192072a42e389e74f0e5e68af90ebf1d69

Comment 8

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8968136 [details]
Bug 1451991 - Devtools: Localstorage didn't list item whose key names "key"

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/236812/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8218cd8d6ec1
Devtools: Localstorage didn't list item whose key names "key" r=nchevobbe

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/8218cd8d6ec1