1452104 - Final Policy Tweaks

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, defect)

Description

[Mike Kaply [:mkaply]]

After discussion, Felipe and I have some final tweaks to some policy names/parameters/comments.

This will be the last "official" policy patch to be uplifted. Hurrah!


Rename BlockSetDesktopBackground to DisableSetDesktopBackground

Update ImportEnterpriseRoots comment to say windows only

Rename AcceptThirdParty enums

CreateMasterPassword -> DisableMasterPasswordCreation

DisableSafeMode - document other platform restriction

DisableSysAddonUpdate -> DisableSystemAddonUpdate

DisableTElemetry -> remove access to about:telemetry

Fix InstallAddons description

InstallAddons->InstallAddonsPermission

RememberPassword -> OfferToSaveLogins

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1452104 - Final tweaks to policy names and params.

Review commit: https://reviewboard.mozilla.org/r/234624/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/234624/

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8965791 [details]
Bug 1452104 - Final tweaks to policy names and params.

https://reviewboard.mozilla.org/r/234624/#review240296

The test for the DisableSysAddonUpdate policy is in another folder:
toolkit/mozapps/extensions/test/xpcshell/test_system_update_enterprisepolicy.js

which will need to be updated too.

With this updated, and assuming that a full folder test passes (`mach test browser/components/enterprisepolicies`), r+

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/13d1bdd6e8ce
Final tweaks to policy names and params. r=Felipe

Comment 4

[Stefan Hindli [:stefan_hindli]]

Backed out changeset 13d1bdd6e8ce (bug 1452104) per developer's request on IRC on a CLOSED TREE

Revision: https://hg.mozilla.org/integration/autoland/rev/13d1bdd6e8cea4a88c3aaa55a5e2b9a236fb8ddb
Push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=13d1bdd6e8cea4a88c3aaa55a5e2b9a236fb8ddb&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/688370d3982d
Backed out changeset 13d1bdd6e8ce per developer's request on IRC on a CLOSED TREE

Comment 6

[Mike Kaply [:mkaply]]

Comment on attachment 8965791 [details]
Bug 1452104 - Final tweaks to policy names and params.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/234624/diff/1-2/

Comment 7

[Mike Kaply [:mkaply]]

Backed out because I forgot to push the second change to review. Relanding.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3860d8fb4a2
Final tweaks to policy names and params. r=Felipe

Comment 9

[Mike Kaply [:mkaply]]

Comment on attachment 8965791 [details]
Bug 1452104 - Final tweaks to policy names and params.

Approval Request Comment
[Feature/Bug causing the regression]: Enterprise policy
[User impact if declined]:
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Not yet
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Policy only, minor changes, has tests.
[String changes made/needed]:

This is the final official patch for Enterprise policies

Felipe and I went through and cleared up any strangeness about naming.

We'd like this in for beta 11 so we can call it the official "Full enterprise policy" beta.

Comment 10

[:Felipe Gomes (needinfo for replies!)]

[Tracking Requested - why for this release]:
Enterprise policies - Final tweaks for the policies names

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/a3860d8fb4a2

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8965791 [details]
Bug 1452104 - Final tweaks to policy names and params.

Needed for the policy engine work. Approved for 60.0b11.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/aab0d3647635