Closed Bug 1452145 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 9965 - [css-typed-om] Fix DCHECK when creating a CSSUnitValue an empty unit.

Categories

(Core :: DOM: CSS Object Model, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 9965 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/9965
Details from upstream follow.

Darren Shen <shend@chromium.org> wrote:
>  [css-typed-om] Fix DCHECK when creating a CSSUnitValue an empty unit.
>  
>  When we create a CSSUnitValue with '' as the unit, we hit a DCHECK
>  in the unit trie code because the length is 0. This is because we don't
>  correctly reject the empty string as an invalid unit.
>  
>  In this patch we fix this. Interestingly, we already have a test to
>  assert that using an empty unit throws type error. However the test used
>  an incorrect variable name, causing it to throw a TypeError anyway,
>  so our tests would've passed no matter what.
>  
>  Bug: 820905
>  Change-Id: I72ab5e4010d892042b2cfddf1014ab79d04a846d
>  Reviewed-on: https://chromium-review.googlesource.com/958624
>  Reviewed-by: nainar <nainar@chromium.org>
>  Commit-Queue: Darren Shen <shend@chromium.org>
>  Cr-Commit-Position: refs/heads/master@{#542693}
>  
>  
>
Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core
Ran 1 tests and 36 subtests
OK     : 1
FAIL   : 36

New tests that have failures or other problems:
/css/css-typed-om/stylevalue-subclasses/numeric-objects/cssUnitValue.tentative.html
    CSSUnitValue can be constructed with Hz: FAIL
    CSSUnitValue can be constructed with Q: FAIL
    CSSUnitValue can be constructed with ch: FAIL
    CSSUnitValue can be constructed with cm: FAIL
    CSSUnitValue can be constructed with deg: FAIL
    CSSUnitValue can be constructed with dpcm: FAIL
    CSSUnitValue can be constructed with dpi: FAIL
    CSSUnitValue can be constructed with dppx: FAIL
    CSSUnitValue can be constructed with em: FAIL
    CSSUnitValue can be constructed with ex: FAIL
    CSSUnitValue can be constructed with fr: FAIL
    CSSUnitValue can be constructed with grad: FAIL
    CSSUnitValue can be constructed with ic: FAIL
    CSSUnitValue can be constructed with in: FAIL
    CSSUnitValue can be constructed with kHz: FAIL
    CSSUnitValue can be constructed with lh: FAIL
    CSSUnitValue can be constructed with mm: FAIL
    CSSUnitValue can be constructed with ms: FAIL
    CSSUnitValue can be constructed with number: FAIL
    CSSUnitValue can be constructed with pc: FAIL
    CSSUnitValue can be constructed with percent: FAIL
    CSSUnitValue can be constructed with pt: FAIL
    CSSUnitValue can be constructed with px: FAIL
    CSSUnitValue can be constructed with rad: FAIL
    CSSUnitValue can be constructed with rem: FAIL
    CSSUnitValue can be constructed with rlh: FAIL
    CSSUnitValue can be constructed with s: FAIL
    CSSUnitValue can be constructed with turn: FAIL
    CSSUnitValue can be constructed with vb: FAIL
    CSSUnitValue can be constructed with vh: FAIL
    CSSUnitValue can be constructed with vi: FAIL
    CSSUnitValue can be constructed with vmax: FAIL
    CSSUnitValue can be constructed with vmin: FAIL
    CSSUnitValue can be constructed with vw: FAIL
    Constructing CSSUnitValue with an empty string as the unit throws a TypeError: FAIL
    Constructing CSSUnitValue with an invalid unit as the unit throws a TypeError: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5eb2f6fefd16
[wpt PR 9965] - [css-typed-om] Fix DCHECK when creating a CSSUnitValue an empty unit., a=testonly
https://hg.mozilla.org/mozilla-central/rev/5eb2f6fefd16
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.