1452173 - Add Leanplum documentation for Users Opting out of pocket in top sites

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Metrics, enhancement, P1)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

We have leanplum documentation in tree [1] that should be updated with the changes from bug 1445799.

Petru, can you take care of this?

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

[1]: https://searchfox.org/mozilla-central/source/mobile/android/docs/mma.rst

Comment 2

[:sdaswani]

Yes please Petru, nice catch Mike.

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1452173 - Add Leanplum documentation for Users Opting out of pocket in top sites;

Make mention of the new LeanPlum user attribute introduced as per Bug 1445799

Review commit: https://reviewboard.mozilla.org/r/235224/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/235224/

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8966501 [details]
Bug 1452173 - Add Leanplum documentation for Users Opting out of pocket in top sites;

https://reviewboard.mozilla.org/r/235224/#review241158

lgtm! Thanks for the quick turn-around! Documentation can be annoying but it's important so I really appreciate it! :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e041cf30962f
Add Leanplum documentation for Users Opting out of pocket in top sites; r=mcomella

Comment 6

[Chenxia Liu [:liuche]]

Comment on attachment 8966501 [details]
Bug 1452173 - Add Leanplum documentation for Users Opting out of pocket in top sites;

https://reviewboard.mozilla.org/r/235224/#review241166

::: mobile/android/docs/mma.rst:67
(Diff revision 1)
>      "Focus Installed" -> true           // If Focus for Android is installed.
>      "Klar Installed" -> true            // If Klar for Android is installed.
>      "Pocket Installed" -> true          // If Pocket for Android is installed.
>      "Signed In Sync" -> true            // If the user has signed in to Mozilla account.
>      "Default Browser" -> true           // If the user has set Fennec as default browser.
> +    "Pocket in Top Sites" -> true       // If Top Sites home panel contain websites recommended by Pocket

Nit: this sounds kind of passive, maybe something like "If Pocket recommendations are enabled (by default or through user action)"

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/e041cf30962f

Comment 8

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1452173 - Add Leanplum documentation for Users Opting out of pocket in top sites;

Make mention of the new LeanPlum user attribute introduced as per Bug 1445799

Review commit: https://reviewboard.mozilla.org/r/235576/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/235576/

Comment 9

[Petru-Mugurel Lingurar [:petru]]

(In reply to Chenxia Liu [:liuche] - not actively working on Fennec from comment #6)
> Comment on attachment 8966501 [details]
> Bug 1452173 - Add Leanplum documentation for Users Opting out of pocket in
> top sites;
> 
> https://reviewboard.mozilla.org/r/235224/#review241166
> 
> ::: mobile/android/docs/mma.rst:67
> (Diff revision 1)
> >      "Focus Installed" -> true           // If Focus for Android is installed.
> >      "Klar Installed" -> true            // If Klar for Android is installed.
> >      "Pocket Installed" -> true          // If Pocket for Android is installed.
> >      "Signed In Sync" -> true            // If the user has signed in to Mozilla account.
> >      "Default Browser" -> true           // If the user has set Fennec as default browser.
> > +    "Pocket in Top Sites" -> true       // If Top Sites home panel contain websites recommended by Pocket
> 
> Nit: this sounds kind of passive, maybe something like "If Pocket
> recommendations are enabled (by default or through user action)"

Thanks Chenxia!
Because the initial change has already been merged I've made a new ticket for this - bug 1453276

Comment 10

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8966915 [details]
Bug 1452173 - Add Leanplum documentation for Users Opting out of pocket in top sites;

This is redundant to bug 1453276.