Add Leanplum documentation for Users Opting out of pocket in top sites

RESOLVED FIXED in Firefox 61

Status

()

P1
normal
RESOLVED FIXED
9 months ago
8 months ago

People

(Reporter: mcomella, Assigned: petru)

Tracking

unspecified
Firefox 61
All
Android
Points:
---

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

We have leanplum documentation in tree [1] that should be updated with the changes from bug 1445799.

Petru, can you take care of this?
Flags: needinfo?(petru.lingurar)
Yes please Petru, nice catch Mike.
Comment hidden (mozreview-request)
(Assignee)

Updated

8 months ago
Assignee: nobody → petru.lingurar
Flags: needinfo?(petru.lingurar)
Attachment #8966501 - Flags: review?(michael.l.comella)
(Reporter)

Comment 4

8 months ago
mozreview-review
Comment on attachment 8966501 [details]
Bug 1452173 - Add Leanplum documentation for Users Opting out of pocket in top sites;

https://reviewboard.mozilla.org/r/235224/#review241158

lgtm! Thanks for the quick turn-around! Documentation can be annoying but it's important so I really appreciate it! :)
Attachment #8966501 - Flags: review?(michael.l.comella) → review+

Comment 5

8 months ago
Pushed by michael.l.comella@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e041cf30962f
Add Leanplum documentation for Users Opting out of pocket in top sites; r=mcomella

Comment 6

8 months ago
mozreview-review
Comment on attachment 8966501 [details]
Bug 1452173 - Add Leanplum documentation for Users Opting out of pocket in top sites;

https://reviewboard.mozilla.org/r/235224/#review241166

::: mobile/android/docs/mma.rst:67
(Diff revision 1)
>      "Focus Installed" -> true           // If Focus for Android is installed.
>      "Klar Installed" -> true            // If Klar for Android is installed.
>      "Pocket Installed" -> true          // If Pocket for Android is installed.
>      "Signed In Sync" -> true            // If the user has signed in to Mozilla account.
>      "Default Browser" -> true           // If the user has set Fennec as default browser.
> +    "Pocket in Top Sites" -> true       // If Top Sites home panel contain websites recommended by Pocket

Nit: this sounds kind of passive, maybe something like "If Pocket recommendations are enabled (by default or through user action)"

Comment 7

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e041cf30962f
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Comment hidden (mozreview-request)
(Assignee)

Updated

8 months ago
Attachment #8966915 - Attachment is obsolete: true
Attachment #8966915 - Flags: review?(sdaswani)
(Assignee)

Comment 9

8 months ago
(In reply to Chenxia Liu [:liuche] - not actively working on Fennec from comment #6)
> Comment on attachment 8966501 [details]
> Bug 1452173 - Add Leanplum documentation for Users Opting out of pocket in
> top sites;
> 
> https://reviewboard.mozilla.org/r/235224/#review241166
> 
> ::: mobile/android/docs/mma.rst:67
> (Diff revision 1)
> >      "Focus Installed" -> true           // If Focus for Android is installed.
> >      "Klar Installed" -> true            // If Klar for Android is installed.
> >      "Pocket Installed" -> true          // If Pocket for Android is installed.
> >      "Signed In Sync" -> true            // If the user has signed in to Mozilla account.
> >      "Default Browser" -> true           // If the user has set Fennec as default browser.
> > +    "Pocket in Top Sites" -> true       // If Top Sites home panel contain websites recommended by Pocket
> 
> Nit: this sounds kind of passive, maybe something like "If Pocket
> recommendations are enabled (by default or through user action)"

Thanks Chenxia!
Because the initial change has already been merged I've made a new ticket for this - bug 1453276
Attachment #8966501 - Flags: review?(sdaswani)
Attachment #8966915 - Attachment is obsolete: false
Attachment #8966915 - Flags: review?(michael.l.comella)
Comment on attachment 8966915 [details]
Bug 1452173 - Add Leanplum documentation for Users Opting out of pocket in top sites;

This is redundant to bug 1453276.
Attachment #8966915 - Attachment is obsolete: true
Attachment #8966915 - Flags: review?(michael.l.comella)
You need to log in before you can comment on or make changes to this bug.