Closed Bug 1452185 Opened 2 years ago Closed 2 years ago

Remove nsIDOMXULElement

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

No description provided.
Jorg, you'll want to fix the use in suite/browser/nsTypeAheadFind.js.
Thanks for the heads-up. The SeaMonkey people are in charge of suite/.
Flags: needinfo?(frgrahl)
These are unused in C++, and the JS bits don't go through this interface
(instead they end up calling things off the relevant XBL prototypes by finding
them on the node's proto chain).

MozReview-Commit-ID: 4FTyFCl4DRt
Attachment #8965887 - Flags: review?(bgrinstead)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
MozReview-Commit-ID: 2JIybnXaudR
Attachment #8965888 - Flags: review?(kyle)
MozReview-Commit-ID: Ft5MnbFtyB9
Attachment #8965889 - Flags: review?(kyle)
MozReview-Commit-ID: HfFtcj64z2Q
Attachment #8965890 - Flags: review?(kyle)
Thanks Jorg. Took care if it.
Flags: needinfo?(frgrahl)
Comment on attachment 8965888 [details] [diff] [review]
part 2.  Remove nsIDOMXULElement use in JS

Review of attachment 8965888 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't realize the eslint eqeqeq rule is turned off almost everywhere, so while ===/!== should apply, it's hard to say that it's worth it since it'll start causing style conflicts across the codebase.
Attachment #8965888 - Flags: review?(kyle) → review+
Attachment #8965889 - Flags: review?(kyle) → review+
Attachment #8965890 - Flags: review?(kyle) → review+
Attachment #8965887 - Flags: review?(bgrinstead) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f81d6a5b561d
part 1.  Remove unused nsIDOMXULContainerElement bits.  r=mossop
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ed41cdddaaf
part 2.  Remove nsIDOMXULElement use in JS.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/b148ee743b26
part 3.  Remove unnecessary nsIDOMXULElement includes.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/8949e2fb8bb3
part 4.  Remove nsIDOMXULElement.  r=qdot
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.