1452185 - Remove nsIDOMXULElement

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Comment 1

[Boris Zbarsky [:bzbarsky]]

Jorg, you'll want to fix the use in suite/browser/nsTypeAheadFind.js.

Comment 2

[Jorg K (CEST = GMT+2)]

Thanks for the heads-up. The SeaMonkey people are in charge of suite/.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Remove unused nsIDOMXULContainerElement bits

These are unused in C++, and the JS bits don't go through this interface
(instead they end up calling things off the relevant XBL prototypes by finding
them on the node's proto chain).

MozReview-Commit-ID: 4FTyFCl4DRt

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Remove nsIDOMXULElement use in JS

MozReview-Commit-ID: 2JIybnXaudR

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Remove unnecessary nsIDOMXULElement includes

MozReview-Commit-ID: Ft5MnbFtyB9

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: part 4. Remove nsIDOMXULElement

MozReview-Commit-ID: HfFtcj64z2Q

Comment 7

[Frank-Rainer Grahl (:frg)]

Thanks Jorg. Took care if it.

Comment 8

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Comment on attachment 8965888 [details] [diff] [review]
part 2.  Remove nsIDOMXULElement use in JS

Review of attachment 8965888 [details] [diff] [review]:
-----------------------------------------------------------------

I didn't realize the eslint eqeqeq rule is turned off almost everywhere, so while ===/!== should apply, it's hard to say that it's worth it since it'll start causing style conflicts across the codebase.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f81d6a5b561d
part 1.  Remove unused nsIDOMXULContainerElement bits.  r=mossop
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ed41cdddaaf
part 2.  Remove nsIDOMXULElement use in JS.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/b148ee743b26
part 3.  Remove unnecessary nsIDOMXULElement includes.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/8949e2fb8bb3
part 4.  Remove nsIDOMXULElement.  r=qdot

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f81d6a5b561d
https://hg.mozilla.org/mozilla-central/rev/8ed41cdddaaf
https://hg.mozilla.org/mozilla-central/rev/b148ee743b26
https://hg.mozilla.org/mozilla-central/rev/8949e2fb8bb3