1452213 - RunnableJobsProcess doesn't set RunnableJob's job_group correctly

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Data Ingestion, defect, P1)

Description

[Ed Morley [:emorley]]

eslint reported:
treeherder/etl/runnable_jobs.py:81,16: Unused variable 'job_group' (W0612: unused-variable)

However upon inspection it appears that `job_group` should be being used, when the RunnableJob object is created, but it's not:
https://github.com/mozilla/treeherder/blob/38d0557a0bd686f0bdfdd83d0f0ad4b129d62146/treeherder/etl/runnable_jobs.py#L101-L108

...and instead the job_group default (why is there a default?) used instead:
https://github.com/mozilla/treeherder/blob/38d0557a0bd686f0bdfdd83d0f0ad4b129d62146/treeherder/model/models.py#L1249

This seems like a real bug.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3416

Comment 2

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/addd73c8631ee2c005a0139bf0a88fabe3c6a24b
Bug 1452213 - Correctly set RunnableJobs group (#3416)

Previously all created/updated `RunnableJobs` entries were using the
`job_group` default of `2`, rather than the actual job group ID.

Not bothering to add a test since `RunnableJobs` will be going away
once buildbot supported is removed.