1452249 - test_ingest_twice_log_parsing_status_changed seems broken

Status: NEW

(Tree Management :: Treeherder: Data Ingestion, enhancement, P3)

Description

[Ed Morley [:emorley]]

eslint reports:
tests/etl/test_job_ingestion.py:50,8: Statement seems to have no effect (W0104: pointless-statement)

Which refers to:
https://github.com/mozilla/treeherder/blob/7beb3cacc3c846eff2e6524be67a05a265772015/tests/etl/test_job_ingestion.py#L50

I can't tell if that line is meant to be an assert, or if another assert should be added after it, checking what the test is actually trying to verify?

Cameron, do you have any ideas?

Comment 1

[Cameron Dawson [:camd]]

Looks to me like lines 49 and 50 to change status can be removed.  It was done the first time so that the second ingestion would be in that situation.  But after that assert on line 48, the test is done.  Kill it with fire!