Closed
Bug 1452252
Opened 7 years ago
Closed 7 years ago
Fix or remove the remove_perf_signatures command
Categories
(Tree Management :: Perfherder, enhancement, P3)
Tree Management
Perfherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
pylint reports:
treeherder/perf/management/commands/remove_perf_signatures.py:12,4: Method should have "self" as first argumen
Which refers to:
https://github.com/mozilla/treeherder/blob/e64be6b0faa1b9f5eedbea4b41644e93423b0fed/treeherder/perf/management/commands/remove_perf_signatures.py#L12
And the command fails if used:
```
vagrant ~/treeherder $ ./manage.py remove_perf_signatures abc
Traceback (most recent call last):
...
TypeError: handle_label() takes exactly 1 argument (7 given)
```
The command should either be fixed (by adding the missing `self`) or else if not used, removed.
Comment 1•7 years ago
|
||
It is ok to just delete this code.
Comment 2•7 years ago
|
||
| Assignee | ||
Updated•7 years ago
|
Assignee: nobody → emorley
Status: NEW → ASSIGNED
Comment 3•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/db3073277e1c4c8adc78e8d13d14535b01bc5c8e
Bug 1452252 - Remove the remove_perf_signatures command (#3422)
Since it's broken and no longer required.
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•