Closed
Bug 1452304
Opened 6 years ago
Closed 6 years ago
Remove broken publish_result_set_to_pulse command
Categories
(Tree Management :: Treeherder: Data Ingestion, enhancement, P1)
Tree Management
Treeherder: Data Ingestion
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
pylint reports: treeherder/model/management/commands/publish_result_set_to_pulse.py:3,0: No name 'publish_to_pulse' in module 'treeherder.model.tasks' (E0611: no-name-in-module) Which refers to: https://github.com/mozilla/treeherder/blob/58186479d313d37fd5052e8416bfc35523f112b5/treeherder/model/management/commands/publish_result_set_to_pulse.py#L3 It turns out the command has been broken since bug 1113281 in 2015: https://github.com/mozilla/treeherder/commit/38e066918700a61dee1cafa0ee46e60b0e6aa6b8#diff-977722f4425644b9c2ed7229bc4477ebL80 ``` vagrant ~/treeherder $ ./manage.py publish_result_set_to_pulse Traceback (most recent call last): ... File "/home/vagrant/treeherder/treeherder/model/management/commands/publish_result_set_to_pulse.py", line 3, in <module> from treeherder.model.tasks import publish_to_pulse ImportError: cannot import name publish_to_pulse ``` We should just remove it.
Comment 1•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Attachment #8965962 -
Flags: review?(cdawson)
Updated•6 years ago
|
Attachment #8965962 -
Flags: review?(cdawson) → review+
Comment 2•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/66f65de0107e517bcb53443b2b843158062db68e Bug 1452304 - Remove publish_result_set_to_pulse command (#3417) Since it's been broken since 2015, due to the non-existent `publish_to_pulse` import.
Assignee | ||
Updated•6 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•