1452321 - Remove nsIWebBrowserPersistable

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

It's not really used.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Remove nsIWebBrowserPersistable

MozReview-Commit-ID: CCw86gAtKn3

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 8965906 [details] [diff] [review]
Remove nsIWebBrowserPersistable

Review of attachment 8965906 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webbrowserpersist/WebBrowserPersistLocalDocument.cpp
@@ +330,5 @@
>      // persisting the root of this subframe, and not some other
>      // subframe child of this subframe.
> +    ErrorResult err;
> +    loader->StartPersistence(0, this, err);
> +    nsresult rv = err.StealNSResult();

A tiny bit gross, but it's fine.

::: dom/webbrowserpersist/nsIWebBrowserPersistDocument.idl
@@ +187,5 @@
>   * Asynchronous callback for creating a persistable document from some
>   * other object.
>   *
> + * XXXbz This should really be changed to just return a promise that
> + * then gets resolved or rejected...

That would be very nice :-)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e38e1bbb7b7c
Remove nsIWebBrowserPersistable.  r=mystor

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e38e1bbb7b7c