Closed
Bug 1452321
Opened 6 years ago
Closed 6 years ago
Remove nsIWebBrowserPersistable
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
21.61 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
It's not really used.
|
Assignee | |
Comment 1•6 years ago
|
||
MozReview-Commit-ID: CCw86gAtKn3
Attachment #8965906 -
Flags: review?(nika)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8965906 [details] [diff] [review] Remove nsIWebBrowserPersistable Review of attachment 8965906 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/webbrowserpersist/WebBrowserPersistLocalDocument.cpp @@ +330,5 @@ > // persisting the root of this subframe, and not some other > // subframe child of this subframe. > + ErrorResult err; > + loader->StartPersistence(0, this, err); > + nsresult rv = err.StealNSResult(); A tiny bit gross, but it's fine. ::: dom/webbrowserpersist/nsIWebBrowserPersistDocument.idl @@ +187,5 @@ > * Asynchronous callback for creating a persistable document from some > * other object. > * > + * XXXbz This should really be changed to just return a promise that > + * then gets resolved or rejected... That would be very nice :-)
Attachment #8965906 -
Flags: review?(nika) → review+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e38e1bbb7b7c Remove nsIWebBrowserPersistable. r=mystor
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e38e1bbb7b7c
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•