Closed Bug 1452509 Opened 2 years ago Closed 2 years ago

Move --enable-alsa --enable-pulseaudio to moz.configure

Categories

(Firefox Build System :: General, enhancement)

Unspecified
Linux
enhancement
Not set
normal

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: jbeich, Assigned: jbeich)

Details

Attachments

(4 files)

No description provided.
OS: Unspecified → Linux
Assigning to Jan Beich since the patches attached belong to you.
Assignee: nobody → jbeich
Attachment #8966064 - Flags: review?(core-build-config-reviews)
Attachment #8966065 - Flags: review?(core-build-config-reviews)
Attachment #8966066 - Flags: review?(core-build-config-reviews)
Attachment #8966067 - Flags: review?(core-build-config-reviews)
Attachment #8966064 - Flags: review?(core-build-config-reviews) → review?(nfroyd)
Attachment #8966065 - Flags: review?(core-build-config-reviews) → review?(nfroyd)
Comment on attachment 8966064 [details]
Bug 1452509 - Require Jack package for --enable-jack build.

https://reviewboard.mozilla.org/r/234778/#review241822
Attachment #8966064 - Flags: review?(nfroyd) → review+
Comment on attachment 8966065 [details]
Bug 1452509 - Make -DMOZ_ALSA global and prune duplicate -DMOZ_PULSEAUDIO.

https://reviewboard.mozilla.org/r/234780/#review241824
Attachment #8966065 - Flags: review?(nfroyd) → review+
Attachment #8966066 - Flags: review?(core-build-config-reviews) → review?(nfroyd)
Comment on attachment 8966066 [details]
Bug 1452509 - Move --enable-alsa to moz.configure.

https://reviewboard.mozilla.org/r/234782/#review241826

Thank you!
Attachment #8966066 - Flags: review?(nfroyd) → review+
Comment on attachment 8966067 [details]
Bug 1452509 - Move --enable-pulseaudio to moz.configure.

https://reviewboard.mozilla.org/r/234784/#review241828

Thank you!
Attachment #8966067 - Flags: review+
Attachment #8966067 - Flags: review?(core-build-config-reviews)
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f0b124af6c5b
Require Jack package for --enable-jack build. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/41ed6d6a2a90
Make -DMOZ_ALSA global and prune duplicate -DMOZ_PULSEAUDIO. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/1aa13977ac86
Move --enable-alsa to moz.configure. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/dc42a9d9c636
Move --enable-pulseaudio to moz.configure. r=froydnj
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.