1452534 - Convert InspectorUtils::IsInheritedProperty to use Stylo

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1452534 part 1 - Use Servo code to check whether a property is inherited.

Review commit: https://reviewboard.mozilla.org/r/234850/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/234850/

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1452534 part 2 - Remove nsCSSProps::kSIDTable.

Review commit: https://reviewboard.mozilla.org/r/234852/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/234852/

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1452534 part 3 - Remove stylestruct_ field from CSS_PROP macro.

Review commit: https://reviewboard.mozilla.org/r/234854/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/234854/

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1452534 part 4 - Remove unused ComputedStyle::{IsReset,IsInherited}.

Review commit: https://reviewboard.mozilla.org/r/234856/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/234856/

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8966103 [details]
Bug 1452534 part 1 - Use Servo code to check whether a property is inherited.

https://reviewboard.mozilla.org/r/234850/#review240466

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8966104 [details]
Bug 1452534 part 2 - Remove nsCSSProps::kSIDTable.

https://reviewboard.mozilla.org/r/234852/#review240468

Thanks!

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8966105 [details]
Bug 1452534 part 3 - Remove stylestruct_ field from CSS_PROP macro.

https://reviewboard.mozilla.org/r/234854/#review240470

Nice cleanup :)

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8966107 [details]
Bug 1452534 part 4 - Remove unused ComputedStyle::{IsReset,IsInherited}.

https://reviewboard.mozilla.org/r/234856/#review240472

::: layout/style/ComputedStyle.h
(Diff revision 1)
>    inline void StartBackgroundImageLoads();
>  
> -  static bool IsReset(const nsStyleStructID aSID) {
> -    MOZ_ASSERT(0 <= aSID && aSID < nsStyleStructID_Length,
> -               "must be an inherited or reset SID");
> -    return nsStyleStructID_Reset_Start <= aSID;

Can we remove `_reset_start` and such?

Comment 9

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8966107 [details]
Bug 1452534 part 4 - Remove unused ComputedStyle::{IsReset,IsInherited}.

https://reviewboard.mozilla.org/r/234856/#review240472

> Can we remove `_reset_start` and such?

Maybe not that trivial. We still need it for `nsStyleStructID_{Inherited,Reset}_Count` which is referenced `NS_STYLE_{INHERITED,RESET}_STRUCT_MASK` we use elsewhere.

Comment 10

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Servo PR

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e2847e579e9
part 1 - Use Servo code to check whether a property is inherited. r=emilio
https://hg.mozilla.org/integration/autoland/rev/7ce482eb39fc
part 2 - Remove nsCSSProps::kSIDTable. r=emilio
https://hg.mozilla.org/integration/autoland/rev/bf051d225f32
part 3 - Remove stylestruct_ field from CSS_PROP macro. r=emilio
https://hg.mozilla.org/integration/autoland/rev/1e06dbb241b1
part 4 - Remove unused ComputedStyle::{IsReset,IsInherited}. r=emilio

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/9e2847e579e9
https://hg.mozilla.org/mozilla-central/rev/7ce482eb39fc
https://hg.mozilla.org/mozilla-central/rev/bf051d225f32
https://hg.mozilla.org/mozilla-central/rev/1e06dbb241b1