Closed Bug 1452601 Opened 2 years ago Closed 2 years ago

Remove LayersId::EqualFn

Categories

(Core :: Graphics: Layers, enhancement)

Other Branch
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

When I changed the layersid from a plain uint64_t into a struct (in bug 1448490), I added LayersId::HashFn and LayersId::EqualFn helper structs for use when creating std::unordered_map instances with LayersId as the key. Turns out the EqualFn is unnecessary, because the default implementation will use std::equal_to which delegates to LayersId::operator== if it exists (which it does). So we can just remove EqualFn entirely and it will behave exactly the same.
Comment on attachment 8966186 [details]
Bug 1452601 - Drop LayersId::EqualFn as it is unnecessary.

https://reviewboard.mozilla.org/r/234932/#review240668
Attachment #8966186 - Flags: review?(botond) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c55a88eebf53
Drop LayersId::EqualFn as it is unnecessary. r=botond
https://hg.mozilla.org/mozilla-central/rev/c55a88eebf53
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.