1452601 - Remove LayersId::EqualFn

Status: RESOLVED FIXED

(Core :: Graphics: Layers, enhancement)

Description

[Kartikaya Gupta (email:[e-mail])]

When I changed the layersid from a plain uint64_t into a struct (in bug 1448490), I added LayersId::HashFn and LayersId::EqualFn helper structs for use when creating std::unordered_map instances with LayersId as the key. Turns out the EqualFn is unnecessary, because the default implementation will use std::equal_to which delegates to LayersId::operator== if it exists (which it does). So we can just remove EqualFn entirely and it will behave exactly the same.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1452601 - Drop LayersId::EqualFn as it is unnecessary.

It's not needed, because by default std::unorderd_map will use
std::equal_to which delegates to the operator== on LayersId which does
the same thing. We don't need to reimplement it.

Review commit: https://reviewboard.mozilla.org/r/234932/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/234932/

Comment 2

[Botond Ballo [:botond]]

Comment on attachment 8966186 [details]
Bug 1452601 - Drop LayersId::EqualFn as it is unnecessary.

https://reviewboard.mozilla.org/r/234932/#review240668

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c55a88eebf53
Drop LayersId::EqualFn as it is unnecessary. r=botond

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/c55a88eebf53