Closed Bug 1452624 Opened 2 years ago Closed Last year

Remove the "filefield" binding

Categories

(Toolkit :: XUL Widgets, task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: Paolo, Assigned: Paolo)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

This is only used in the Preferences window in mozilla-central, and some of its display features are not used.
Blocks: 1453592
Jared, I didn't spend time reimplementing the folder icon here because I believe the meaning of the text field is clear enough, and we actually save a little bit of I/O. We keep the logic for the special "Desktop" and "Downloads" labels. I also made the button size align with the other buttons. Feel free to ask the UX team for review if you think it's needed.
Also, I kept the code close to the existing one, even if there's room for improvement, but I had to change the use of "onsyncfrompreference" because it ends up setting the "value" attribute, which is a no-op on "filefield" but makes the textbox display the integer value of the preference.
Comment on attachment 8967309 [details]
Bug 1452624 - Part 2 - Remove the "filefield" binding.

https://reviewboard.mozilla.org/r/236014/#review241800

Assuming we are OK with the UI change - the removal looks good to me!
Attachment #8967309 - Flags: review?(bgrinstead) → review+
Comment on attachment 8967308 [details]
Bug 1452624 - Part 1 - Replace the "filefield" binding with a regular textbox.

https://reviewboard.mozilla.org/r/236012/#review242790

We should try to continue to maintain the graphical component of the directory picker.

This can be achieved by setting a background-image on the field and setting a padding-inline-start equal to the width of the image (plus some extra pixels on each side of it). The improvement to I/O when loading the preferences page seems prematurely optimized (and unmeasured).
Attachment #8967308 - Flags: review?(jaws) → review-
Comment on attachment 8967308 [details]
Bug 1452624 - Part 1 - Replace the "filefield" binding with a regular textbox.

https://reviewboard.mozilla.org/r/236012/#review244290
Attachment #8967308 - Flags: review?(jaws) → review+
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c4603a9efe6d
Part 1 - Replace the "filefield" binding with a regular textbox. r=jaws
https://hg.mozilla.org/integration/mozilla-inbound/rev/d48d4c91b804
Part 2 - Remove the "filefield" binding. r=bgrins
Depends on: 1455928
https://hg.mozilla.org/mozilla-central/rev/c4603a9efe6d
https://hg.mozilla.org/mozilla-central/rev/d48d4c91b804
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Type: enhancement → task
Blocks: 284532
You need to log in before you can comment on or make changes to this bug.