1452624 - Remove the "filefield" binding

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task, P1)

Description

[:Paolo Amadini]

This is only used in the Preferences window in mozilla-central, and some of its display features are not used.

Comment 1

[:Paolo Amadini]

Attachment: Bug 1452624 - Part 1 - Replace the "filefield" binding with a regular textbox.

The regular textbox does not display a folder icon anymore. This has the advantage of reducing I/O when initializing the preferences page.

Review commit: https://reviewboard.mozilla.org/r/236012/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/236012/

Comment 2

[:Paolo Amadini]

Attachment: Bug 1452624 - Part 2 - Remove the "filefield" binding.

Review commit: https://reviewboard.mozilla.org/r/236014/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/236014/

Comment 3

[:Paolo Amadini]

Jared, I didn't spend time reimplementing the folder icon here because I believe the meaning of the text field is clear enough, and we actually save a little bit of I/O. We keep the logic for the special "Desktop" and "Downloads" labels. I also made the button size align with the other buttons. Feel free to ask the UX team for review if you think it's needed.

Comment 4

[:Paolo Amadini]

Also, I kept the code close to the existing one, even if there's room for improvement, but I had to change the use of "onsyncfrompreference" because it ends up setting the "value" attribute, which is a no-op on "filefield" but makes the textbox display the integer value of the preference.

Comment 5

[:Paolo Amadini]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3a066691cbfd398362ce6042cb94b5023c751b1

Comment 6

[Brian Grinstead [:bgrins]]

Comment on attachment 8967309 [details]
Bug 1452624 - Part 2 - Remove the "filefield" binding.

https://reviewboard.mozilla.org/r/236014/#review241800

Assuming we are OK with the UI change - the removal looks good to me!

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8967308 [details]
Bug 1452624 - Part 1 - Replace the "filefield" binding with a regular textbox.

https://reviewboard.mozilla.org/r/236012/#review242790

We should try to continue to maintain the graphical component of the directory picker.

This can be achieved by setting a background-image on the field and setting a padding-inline-start equal to the width of the image (plus some extra pixels on each side of it). The improvement to I/O when loading the preferences page seems prematurely optimized (and unmeasured).

Comment 8

[:Paolo Amadini]

Comment on attachment 8967308 [details]
Bug 1452624 - Part 1 - Replace the "filefield" binding with a regular textbox.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/236012/diff/1-2/

Comment 9

[:Paolo Amadini]

Comment on attachment 8967309 [details]
Bug 1452624 - Part 2 - Remove the "filefield" binding.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/236014/diff/1-2/

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8967308 [details]
Bug 1452624 - Part 1 - Replace the "filefield" binding with a regular textbox.

https://reviewboard.mozilla.org/r/236012/#review244290

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c4603a9efe6d
Part 1 - Replace the "filefield" binding with a regular textbox. r=jaws
https://hg.mozilla.org/integration/mozilla-inbound/rev/d48d4c91b804
Part 2 - Remove the "filefield" binding. r=bgrins

Comment 12

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/c4603a9efe6d
https://hg.mozilla.org/mozilla-central/rev/d48d4c91b804