1452788 - Localize "Downloads" folder display name

Status: NEW

(Firefox for iOS :: Localization, enhancement, P3)

Description

[Justin D'Arcangelo [:justindarc]]

See: https://developer.apple.com/library/content/documentation/FileManagement/Conceptual/FileSystemAdvancedPT/LocalizingtheNameofaDirectory/LocalizingtheNameofaDirectory.html

Comment 1

[Justin D'Arcangelo [:justindarc]]

We will likely need to modify `xliff-to-strings.py` in the `ios-l10n-scripts` project to export the file hierarchy to support this: https://github.com/mozilla-mobile/ios-l10n-scripts/blob/master/xliff-to-strings.py

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

If we add this string as follow to the application (Strings.swift):

   NSLocalizedString("Downloads", tableName: "DownloadsFolder", value: "Downloads", comment: "Name of the Downloads folder")

That will result in the following App bundle after localization:

   Client.app/af.lproj/DownloadsFolder.strings
   Client.app/an.lproj/DownloadsFolder.strings
   Client.app/ar.lproj/DownloadsFolder.strings

So I think to make this work, we simply need to do this:

   create directory Downloads.localized
   create directory Downloads.localized/.localized

   for each *.lproj in appBundle/:
      if appBundle/$languageCode.lproj/DownloadsFolder.strings exists:
          copy to Downloads.localized/.localized/$languageCode.strings

Comment 3

[Justin D'Arcangelo [:justindarc]]

After some research, it seems that this approach to localizing folder names is not currently supported in the iOS "Files" app. Because of this, we'll ship v12.0 with an unlocalized "Downloads" folder. Should this get supported by the iOS "Files" app in the future, we can always implement this later. Moving to tracking+ since there's no possible solution at present :-/