Closed
Bug 1452827
Opened 7 years ago
Closed 7 years ago
XPIInstall has a bunch of cruft that needs to be cleaned up
Categories
(Toolkit :: Add-ons Manager, enhancement)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: kmag, Assigned: kmag)
References
Details
Attachments
(1 file)
No description provided.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8966434 [details]
Bug 1452827: Cleanup a bunch of duplication and cruft in XPIInstall.jsm.
https://reviewboard.mozilla.org/r/235140/#review241072
nice, thanks
::: toolkit/mozapps/extensions/internal/XPIInstall.jsm:63
(Diff revision 1)
> + "@mozilla.org/rdf/datasource;1?name=in-memory-datasource", "nsIRDFDataSource");
> +const parseRDFString = Components.Constructor(
> + "@mozilla.org/rdf/xml-parser;1", "nsIRDFXMLParser", "parseString");
> +
> +XPCOMUtils.defineLazyServiceGetters(this, {
> + aomStartup: ["@mozilla.org/addons/addon-manager-startup;1", "amIAddonManagerStartup"],
this doesn't appear to be used
Attachment #8966434 -
Flags: review?(aswan) → review+
Assignee | ||
Comment 3•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc804d75911a04cc104898a0cee538e761f5582b
Bug 1452827: Cleanup a bunch of duplication and cruft in XPIInstall.jsm. r=aswan
Assignee | ||
Comment 4•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7709fe9d13c7f16371995ea48dea6d08dbfaeb64
Bug 1452827: Follow-up: Flush the jar cache after fetch()ing a jar: URI at install. r=bustage
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bc804d75911a
https://hg.mozilla.org/mozilla-central/rev/7709fe9d13c7
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Comment 6•7 years ago
|
||
Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.
Flags: needinfo?(kmaglione+bmo)
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(kmaglione+bmo) → qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•