1452827 - XPIInstall has a bunch of cruft that needs to be cleaned up

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement)

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1452827: Cleanup a bunch of duplication and cruft in XPIInstall.jsm.

Review commit: https://reviewboard.mozilla.org/r/235140/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/235140/

Comment 2

[Andrew Swan [:aswan]]

Comment on attachment 8966434 [details]
Bug 1452827: Cleanup a bunch of duplication and cruft in XPIInstall.jsm.

https://reviewboard.mozilla.org/r/235140/#review241072

nice, thanks

::: toolkit/mozapps/extensions/internal/XPIInstall.jsm:63
(Diff revision 1)
> +  "@mozilla.org/rdf/datasource;1?name=in-memory-datasource", "nsIRDFDataSource");
> +const parseRDFString = Components.Constructor(
> +  "@mozilla.org/rdf/xml-parser;1", "nsIRDFXMLParser", "parseString");
> +
> +XPCOMUtils.defineLazyServiceGetters(this, {
> +  aomStartup: ["@mozilla.org/addons/addon-manager-startup;1", "amIAddonManagerStartup"],

this doesn't appear to be used

Comment 3

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bc804d75911a04cc104898a0cee538e761f5582b
Bug 1452827: Cleanup a bunch of duplication and cruft in XPIInstall.jsm. r=aswan

Comment 4

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7709fe9d13c7f16371995ea48dea6d08dbfaeb64
Bug 1452827: Follow-up: Flush the jar cache after fetch()ing a jar: URI at install. r=bustage

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/bc804d75911a
https://hg.mozilla.org/mozilla-central/rev/7709fe9d13c7

Comment 6

[Victor Carciu]

Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.