Closed Bug 1452836 Opened 2 years ago Closed 2 years ago

Dark theme sub menu in the bookmarks toolbar are illegible (Mac OSX)

Categories

(Firefox :: Theme, defect, P1)

60 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 61
Tracking Status
firefox-esr52 --- unaffected
firefox59 --- unaffected
firefox60 --- unaffected
firefox61 + verified

People

(Reporter: abenson, Assigned: jaws)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(3 files)

When the dark theme is enabled, sub menus in the Bookmarks menu are improperly styled and are illegible. See attached screenshot.
Summary: Dark theme sub menu in the bookmarks toolbar item are illegible → Dark theme sub menu in the bookmarks toolbar are illegible
This works-for-me on Windows but I can reproduce on Mac.
Blocks: 1417880
Summary: Dark theme sub menu in the bookmarks toolbar are illegible → Dark theme sub menu in the bookmarks toolbar are illegible (Mac OSX)
Keywords: regression
Priority: -- → P1
Whiteboard: [photon-visual]
This is currently marked as a P1 without an assignee. Jared, is there someone at MSU who can work on this or is there someone else available otherwise?
Flags: needinfo?(jaws)
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Flags: needinfo?(jaws)
Attached image Screenshot of patch
The menu arrows look invisible on really dark themes like Breeze Dark: https://addons.mozilla.org/en-US/firefox/addon/breeze-dark-theme/
Comment on attachment 8968527 [details]
Bug 1452836 - Apply the arrowpanel variables to submenus of the bookmarks popup.

https://reviewboard.mozilla.org/r/237216/#review243122

I found two issues:
- menu arrows are not very visible
- this removes the macOS vibrancy effect for the default theme

::: browser/themes/osx/customizableui/panelUI.css:42
(Diff revision 1)
> +#BMB_bookmarksPopup menupopup[placespopup=true] {
> +  -moz-appearance: none;
> +  background: transparent;
> +}

This removes the macOS vibrancy effect on the default theme. Can we target only :-moz-lwtheme ?
Attachment #8968527 - Flags: review?(ntim.bugs)
Comment on attachment 8968527 [details]
Bug 1452836 - Apply the arrowpanel variables to submenus of the bookmarks popup.

https://reviewboard.mozilla.org/r/237216/#review243528

Thanks!
Attachment #8968527 - Flags: review?(ntim.bugs) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/44ea1dc76ef5
Apply the arrowpanel variables to submenus of the bookmarks popup. r=ntim
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/31dc1b39ba36
Apply the arrowpanel variables to submenus of the bookmarks popup. r=ntim
https://hg.mozilla.org/mozilla-central/rev/31dc1b39ba36
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
I reproduced the issues on MacOS 10.13.2 build 61.0a1(2018-04-05.
Confirming the fix on 61.0b9 (64-bit) MacOS 10.13.2.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.