Closed
Bug 1452836
Opened 7 years ago
Closed 7 years ago
Dark theme sub menu in the bookmarks toolbar are illegible (Mac OSX)
Categories
(Firefox :: Theme, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox59 | --- | unaffected |
firefox60 | --- | unaffected |
firefox61 | + | verified |
People
(Reporter: abenson, Assigned: jaws)
References
(Blocks 1 open bug)
Details
(Keywords: regression)
Attachments
(3 files)
When the dark theme is enabled, sub menus in the Bookmarks menu are improperly styled and are illegible. See attached screenshot.
Reporter | ||
Updated•7 years ago
|
Summary: Dark theme sub menu in the bookmarks toolbar item are illegible → Dark theme sub menu in the bookmarks toolbar are illegible
Assignee | ||
Comment 1•7 years ago
|
||
This works-for-me on Windows but I can reproduce on Mac.
Blocks: 1417880
Summary: Dark theme sub menu in the bookmarks toolbar are illegible → Dark theme sub menu in the bookmarks toolbar are illegible (Mac OSX)
Updated•7 years ago
|
status-firefox60:
--- → unaffected
status-firefox61:
--- → affected
Keywords: regression
Priority: -- → P1
Whiteboard: [photon-visual]
Updated•7 years ago
|
status-firefox59:
--- → unaffected
status-firefox-esr52:
--- → unaffected
tracking-firefox61:
--- → +
Comment 2•7 years ago
|
||
This is currently marked as a P1 without an assignee. Jared, is there someone at MSU who can work on this or is there someone else available otherwise?
Flags: needinfo?(jaws)
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Flags: needinfo?(jaws)
Comment 4•7 years ago
|
||
The menu arrows look invisible on really dark themes like Breeze Dark: https://addons.mozilla.org/en-US/firefox/addon/breeze-dark-theme/
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8968527 [details]
Bug 1452836 - Apply the arrowpanel variables to submenus of the bookmarks popup.
https://reviewboard.mozilla.org/r/237216/#review243122
I found two issues:
- menu arrows are not very visible
- this removes the macOS vibrancy effect for the default theme
::: browser/themes/osx/customizableui/panelUI.css:42
(Diff revision 1)
> +#BMB_bookmarksPopup menupopup[placespopup=true] {
> + -moz-appearance: none;
> + background: transparent;
> +}
This removes the macOS vibrancy effect on the default theme. Can we target only :-moz-lwtheme ?
Attachment #8968527 -
Flags: review?(ntim.bugs)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8968527 [details]
Bug 1452836 - Apply the arrowpanel variables to submenus of the bookmarks popup.
https://reviewboard.mozilla.org/r/237216/#review243528
Thanks!
Attachment #8968527 -
Flags: review?(ntim.bugs) → review+
Assignee | ||
Updated•7 years ago
|
Blocks: png-cleanup
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/44ea1dc76ef5
Apply the arrowpanel variables to submenus of the bookmarks popup. r=ntim
Comment 10•7 years ago
|
||
Backed out changeset 44ea1dc76ef5 (bug 1452836) for browser_parsable_css.js failures in chrome://browser/skin/customizableui/panelUI.css on OS X on a CLOSED TREE, a=backout
push that caused the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=44ea1dc76ef50bc77e84ddb26433baf84cb16d84&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&selectedJob=174410093&filter-searchStr=OS+X+10.10+opt+Mochitests+with+e10s+test-macosx64%2Fopt-mochitest-browser-chrome-e10s-7+M-e10s%28bc7%29
failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=174410093&repo=autoland
backout: https://hg.mozilla.org/integration/autoland/rev/c064e452478eba9d8be71974a79c18fe0dc46acc
Comment 11•7 years ago
|
||
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/31dc1b39ba36
Apply the arrowpanel variables to submenus of the bookmarks popup. r=ntim
Comment 12•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Updated•6 years ago
|
Flags: qe-verify+
Comment 13•6 years ago
|
||
I reproduced the issues on MacOS 10.13.2 build 61.0a1(2018-04-05.
Confirming the fix on 61.0b9 (64-bit) MacOS 10.13.2.
Updated•6 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•