1452881 - Remove usechromesheets support.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

Nobody uses this attribute, and I want to simplify the loader constructors.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Hey Richard, PSA, this is only used in one place in comm-central, which is a theme:

  https://searchfox.org/comm-central/rev/fae4b6658306aabf5b4193947ea49fbf6fb04c42/suite/themes/modern/communicator/sidebar/sidebar.css#89

Would you want me to hold off on it because of that?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1452881: Remove usechromesheets support.

Review commit: https://reviewboard.mozilla.org/r/235214/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/235214/

Comment 3

[Richard Marti (:Paenglab)]

I'm working only on TB and not SM. But SM is broken ATM, so I think they don't hold you off.

Let's better ask SM people. Frank-Rainer and Ian can you reply to Emilio's comment 1?

Comment 4

[Frank-Rainer Grahl (:frg)]

Sidebar has been broken by a rdf removal change and Modern with a change which removed full theme support. We will fix it later for SeaMonkey. No need to block or change it currently.

Comment 5

[Cameron McCormack (:heycam)]

Comment on attachment 8966499 [details]
Bug 1452881: Remove usechromesheets support.

https://reviewboard.mozilla.org/r/235214/#review241228

Looks good.  I don't know when the last time usechromesheets="" would have been used in mozilla-central, but my "git log -S" has been running for a while and hasn't come up with anything...

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/06c4c125d022
Remove usechromesheets support. r=heycam

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/06c4c125d022