1452916 - Some error reporting cleanups.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Emilio Cobos Álvarez (:emilio)]

I'm looking into where the devtools code lives for this, but for now let's do this. We'll need to add more state here than the pref, but that'll come.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1452916: Expose the error reporting pref.

Review commit: https://reviewboard.mozilla.org/r/235266/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/235266/

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1452916: Remove dead error reporting code.

Review commit: https://reviewboard.mozilla.org/r/235268/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/235268/

Comment 3

[Bobby Holley (:bholley)]

Comment on attachment 8966550 [details]
Bug 1452916: Expose the error reporting pref.

https://reviewboard.mozilla.org/r/235266/#review241064

::: layout/style/ErrorReporter.cpp:166
(Diff revision 1)
>  }
>  
>  void
>  ErrorReporter::OutputError()
>  {
> +  MOZ_RELEASE_ASSERT(NS_IsMainThread());

Given that OutputError is currently hot, I think we probably don't want to add a TLS lookup here in release builds. Switch to a MOZ_ASSERT?

::: layout/style/ServoBindings.cpp:2688
(Diff revision 1)
>  {
> -  MOZ_ASSERT(NS_IsMainThread());
> +  if (!reporter->ShouldReportErrors()) {
> +    return;
> +  }
> +
> +  MOZ_RELEASE_ASSERT(NS_IsMainThread());

Same here.

Comment 4

[Bobby Holley (:bholley)]

Comment on attachment 8966551 [details]
Bug 1452916: Remove dead error reporting code.

https://reviewboard.mozilla.org/r/235268/#review241066

Nice. Though why do we still have nsCSSScanner at all?

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Bobby Holley (:bholley) from comment #4)
> Nice. Though why do we still have nsCSSScanner at all?

It's currently still used by DevTools.  I am aiming to replace those usages with Stylo code in bug 1410184.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81fd385c9197
Expose the error reporting pref. r=bholley
https://hg.mozilla.org/integration/autoland/rev/f6e323494896
Remove dead error reporting code. r=bholley

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/81fd385c9197
https://hg.mozilla.org/mozilla-central/rev/f6e323494896