Closed Bug 1452935 Opened 6 years ago Closed 6 years ago

Remove now-empty `addons.activeExperiment` and check pipeline impact

Categories

(Toolkit :: Telemetry, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: janerik, Assigned: janerik)

References

Details

Attachments

(2 files)

Since bug 1443608 `addons.activeExperiment` is already empty, bug 1420908 removes most of the machinery.

Before we finally remove the object from the ping payload, we should double-check the pipeline impact.
Blocks: 1415284
Depends on: 1420908
Priority: -- → P2
Assignee: nobody → jrediger
Priority: P2 → P1
MozReview-Commit-ID: 2CE6RscQjRV
Blocks: 1455347
Attachment #8968566 - Flags: review?(gfritzsche)
Comment on attachment 8968566 [details] [diff] [review]
Remove empty `addons.activeExperiment`

Review of attachment 8968566 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good, thanks.

Let's also update the environment documentation, in this patch or a separate patch on this bug.
How about we remove `activeExperiment` from the ping format section and add a version history, similar to the main ping documentation?
Attachment #8968566 - Flags: review?(gfritzsche) → review+
MozReview-Commit-ID: 3TkQMEWJh6T
Attachment #8970856 - Flags: review?(gfritzsche)
Comment on attachment 8970856 [details] [diff] [review]
Remove obsolete documentation for `addons.activeExperiment`

Review of attachment 8970856 [details] [diff] [review]:
-----------------------------------------------------------------

That looks good, cheers!
Attachment #8970856 - Flags: review?(gfritzsche) → review+
Keywords: checkin-needed
Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b908b54e000
Remove empty `addons.activeExperiment` r=gfritzsche
https://hg.mozilla.org/integration/mozilla-inbound/rev/99a0c6510501
Remove obsolete documentation for `addons.activeExperiment` r=gfritzsche
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0b908b54e000
https://hg.mozilla.org/mozilla-central/rev/99a0c6510501
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.