Closed Bug 1452947 Opened 2 years ago Closed 2 years ago

Get rid of useless PtrHolder / PtrHandle dance in style now that URIs are thread-safe.

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → emilio
Comment on attachment 8966571 [details]
Bug 1452947: Remove useless PtrHolder / PtrHandle stuff now that URIs are thread-safe.

https://reviewboard.mozilla.org/r/235298/#review240988


Code analysis found 2 defects in this patch:
 - 2 defects found by clang-tidy

You can run this analysis locally with:
 - `./mach static-analysis check path/to/file.cpp` (C/C++)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: layout/style/nsCSSValue.h:112
(Diff revision 1)
>    URLValueData(const nsAString& aString,
>                 already_AddRefed<URLExtraData> aExtraData);
>    URLValueData(ServoRawOffsetArc<RustString> aString,
>                 already_AddRefed<URLExtraData> aExtraData);
>    // Construct with the actual URI.
> -  URLValueData(already_AddRefed<PtrHolder<nsIURI>> aURI,
> +  URLValueData(already_AddRefed<nsIURI> aURI,

Error: Bad implicit conversion constructor for 'urlvaluedata' [clang-tidy: mozilla-implicit-constructor]

::: layout/style/nsCSSValue.h:115
(Diff revision 1)
>                 already_AddRefed<URLExtraData> aExtraData);
>    // Construct with the actual URI.
> -  URLValueData(already_AddRefed<PtrHolder<nsIURI>> aURI,
> +  URLValueData(already_AddRefed<nsIURI> aURI,
>                 const nsAString& aString,
>                 already_AddRefed<URLExtraData> aExtraData);
> -  URLValueData(already_AddRefed<PtrHolder<nsIURI>> aURI,
> +  URLValueData(already_AddRefed<nsIURI> aURI,

Error: Bad implicit conversion constructor for 'urlvaluedata' [clang-tidy: mozilla-implicit-constructor]
Comment on attachment 8966571 [details]
Bug 1452947: Remove useless PtrHolder / PtrHandle stuff now that URIs are thread-safe.

https://reviewboard.mozilla.org/r/235298/#review241022


Code analysis found 2 defects in this patch:
 - 2 defects found by clang-tidy

You can run this analysis locally with:
 - `./mach static-analysis check path/to/file.cpp` (C/C++)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: layout/style/nsCSSValue.h:112
(Diff revision 2)
>    URLValueData(const nsAString& aString,
>                 already_AddRefed<URLExtraData> aExtraData);
>    URLValueData(ServoRawOffsetArc<RustString> aString,
>                 already_AddRefed<URLExtraData> aExtraData);
>    // Construct with the actual URI.
> -  URLValueData(already_AddRefed<PtrHolder<nsIURI>> aURI,
> +  URLValueData(already_AddRefed<nsIURI> aURI,

Error: Bad implicit conversion constructor for 'urlvaluedata' [clang-tidy: mozilla-implicit-constructor]

::: layout/style/nsCSSValue.h:115
(Diff revision 2)
>                 already_AddRefed<URLExtraData> aExtraData);
>    // Construct with the actual URI.
> -  URLValueData(already_AddRefed<PtrHolder<nsIURI>> aURI,
> +  URLValueData(already_AddRefed<nsIURI> aURI,
>                 const nsAString& aString,
>                 already_AddRefed<URLExtraData> aExtraData);
> -  URLValueData(already_AddRefed<PtrHolder<nsIURI>> aURI,
> +  URLValueData(already_AddRefed<nsIURI> aURI,

Error: Bad implicit conversion constructor for 'urlvaluedata' [clang-tidy: mozilla-implicit-constructor]
Comment on attachment 8966571 [details]
Bug 1452947: Remove useless PtrHolder / PtrHandle stuff now that URIs are thread-safe.

https://reviewboard.mozilla.org/r/235298/#review241232
Attachment #8966571 - Flags: review?(cam) → review+
Oh, relatedly I realize that we can get rid of all of the DefinitelyEqualXXX methods, since we can now call nsIURI::Equals OMT.
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/2aaddcc3fc77
Remove useless PtrHolder / PtrHandle stuff now that URIs are thread-safe. r=heycam
https://hg.mozilla.org/mozilla-central/rev/2aaddcc3fc77
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.