1452957 - reftests should support preferences with Unicode strings

Status: RESOLVED FIXED

(Testing :: Reftest, enhancement, P1)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Right now the reftest extension makes use of `getCharPref` for retrieving strings from preferences, which includes the reftest file objects list which is located in the profile. Sadly this method doesn't support Unicode characters, and as such we have failures like bug 1452913.

To fix that we have to make use of `getStringPref` or even better the Preferences.jsm Javascript module.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1452957 - reftests should support preferences with Unicode strings.

Switching to Preferences.jsm allows the reftest extension
to also support prefernces with Unicode strings.

Review commit: https://reviewboard.mozilla.org/r/235318/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/235318/

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

All the sanity reftest tests fail for this try build:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4ae1a6e0ef316c75c808aafacb73ee567e278d1a&selectedJob=172881274

The problem is that the negative tests are causing problems in resetting a preference. I would suggest that in this case we keep it simple and simply make the change from `getCharPref` to `getStringPref`, and the same for `setCharPref`.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

FYI `getStringPref` and `setStringPref` are new and have been added for Firefox 58. So we will be fine on central.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8966600 [details]
Bug 1452957 - reftests should support preferences with Unicode strings.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/235318/diff/1-2/

Comment 5

[Geoff Brown [:gbrown]]

Comment on attachment 8966600 [details]
Bug 1452957 - reftests should support preferences with Unicode strings.

https://reviewboard.mozilla.org/r/235318/#review241078

I suppose that for any pref with an all-ascii value, getStringPref will return the same content as getCharPref (but in a different type of course) -- that seems safe.

I am a little surprised that changing the type of all of these variables (g.logLevel, etc) to Unicode strings doesn't require any other changes, but I can't see anything specifically wrong, and your try run seems to be greening up nicely.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8966600 [details]
Bug 1452957 - reftests should support preferences with Unicode strings.

https://reviewboard.mozilla.org/r/235318/#review241078

It seems that all of that depends on which internal string class is used for the argument and return value. So what's used here seems to handle both nicely. It's definitely easier to handle as in legacy Python.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a78a6a4e6bf4
reftests should support preferences with Unicode strings. r=gbrown

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/a78a6a4e6bf4