Closed Bug 1452993 Opened 5 years ago Closed 5 years ago
Replace unnecessary Media
Stream Graph::Get Instance call in Media Manager
59 bytes, text/x-review-board-request
dom/media/MediaManager.cpp::4154 MediaStreamGraph::GetInstance(MediaStreamGraph::AUDIO_THREAD_DRIVER, window); found in mozilla::SourceListener::StopSharing This is called at stop of AudioCapture. Since we stop an operating stream the MSG is up and running. We could get the instance of MSG from the stream and stop calling the `MediaStreamGraph::GetInstance()` method. After Bug 1387454 we must specify the sample rate of the graph in `MediaStreamGraph::GetInstance()` method. The instance of the graph is already stored MediaStream. Better to get it from there rather than calling the GetInstance() method and risk using wrong sample rate argument.
Assignee: nobody → achronop
Priority: -- → P3
See Also: → 1387454
Comment on attachment 8966617 [details] Bug 1452993 - Get MSG instance from MediaStream to avoid the risk of creating new instance. https://reviewboard.mozilla.org/r/235330/#review242266
Attachment #8966617 - Flags: review?(padenot) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/5bb64d5081d6 Get MSG instance from MediaStream to avoid the risk of creating new instance. r=padenot
You need to log in before you can comment on or make changes to this bug.