1452993 - Replace unnecessary MediaStreamGraph::GetInstance call in MediaManager

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, defect, P3)

Description

[Alex Chronopoulos [:achronop]]

dom/media/MediaManager.cpp::4154
MediaStreamGraph::GetInstance(MediaStreamGraph::AUDIO_THREAD_DRIVER, window);
found in mozilla::SourceListener::StopSharing

This is called at stop of AudioCapture. Since we stop an operating stream the MSG is up and running. We could get the instance of MSG from the stream and stop calling the `MediaStreamGraph::GetInstance()` method.

After Bug 1387454 we must specify the sample rate of the graph in `MediaStreamGraph::GetInstance()` method. The instance of the graph is already stored MediaStream. Better to get it from there rather than calling the GetInstance() method and risk using wrong sample rate argument.

Comment 1

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1452993 - Get MSG instance from MediaStream to avoid the risk of creating new instance.

Review commit: https://reviewboard.mozilla.org/r/235330/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/235330/

Comment 2

[Paul Adenot (:padenot)]

Comment on attachment 8966617 [details]
Bug 1452993 - Get MSG instance from MediaStream to avoid the risk of creating new instance.

https://reviewboard.mozilla.org/r/235330/#review242266

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bb64d5081d6
Get MSG instance from MediaStream to avoid the risk of creating new instance. r=padenot

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/5bb64d5081d6