Closed Bug 1453011 Opened 7 years ago Closed 7 years ago

Some XPConnect clean-ups

Categories

(Core :: XPConnect, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox61 --- wontfix
firefox62 --- fixed

People

(Reporter: peterv, Assigned: peterv)

Details

Attachments

(4 files)

No description provided.
nsDOMClassInfo was the only thing that inherited from nsXPCClassInfo.
Attachment #8967080 - Flags: review?(bzbarsky)
Attachment #8967083 - Flags: review?(bzbarsky)
Attachment #8967087 - Flags: review?(bzbarsky)
Comment on attachment 8967080 [details] [diff] [review] Remove nsXPCClassInfo v1 r=me
Attachment #8967080 - Flags: review?(bzbarsky) → review+
Comment on attachment 8967082 [details] [diff] [review] Remove some unused nsIXPCScriptable flags v1 >+static const js::ClassExtension XPC_WN_Shared_Proto_ClassExtension = { Didn't the "shared" there mean it was shared between the mods-allowed and non-mods-allowed cases? If so maybe we can clean up the naming, as a followup. There are uses of these constants in dom/base/nsIDOMClassInfo.h. Do you have another patch under this one removing it or something?
Attachment #8967082 - Flags: review?(bzbarsky) → review+
Comment on attachment 8967083 [details] [diff] [review] Remove PostCreatePrototype v1 r=me
Attachment #8967083 - Flags: review?(bzbarsky) → review+
Comment on attachment 8967087 [details] [diff] [review] Remove CONTENT_NODE flag v1 r=me
Attachment #8967087 - Flags: review?(bzbarsky) → review+
Backed out 8 changesets (bug 1453011, bug 1452981, bug 1146316) For xpcshell and mochitest failures on multiple files. CLOSED TREE Log of the failure: https://treeherder.mozilla.org/logviewer.html#?job_id=174810370&repo=mozilla-inbound&lineNumber=1577 09:36:27 INFO - TEST-PASS | devtools/client/performance/test/unit/test_jit-graph-data.js | took 12963ms 09:36:27 INFO - TEST-START | devtools/client/performance/test/unit/test_tree-model-06.js 09:36:31 INFO - TEST-PASS | devtools/client/performance/test/unit/test_tree-model-02.js | took 11871ms 09:36:31 INFO - TEST-START | devtools/client/performance/test/unit/test_tree-model-07.js 09:36:31 INFO - mozcrash Saved minidump as /Users/cltbld/tasks/task_1524241879/build/blobber_upload_dir/F9603462-C1C9-4C82-BB9E-546B04DCD948.dmp 09:36:31 INFO - mozcrash Saved app info as /Users/cltbld/tasks/task_1524241879/build/blobber_upload_dir/F9603462-C1C9-4C82-BB9E-546B04DCD948.extra 09:36:31 WARNING - PROCESS-CRASH | xpcshell-remote.ini:browser/components/extensions/test/xpcshell/test_ext_geckoProfiler_control.js | application crashed [@ ProcessExecutableMemory::release()] 09:36:31 INFO - Crash dump filename: /var/folders/x8/56fhxqzs7rx3spfwdg5l65t800000w/T/xpc-other-Wm7KED/F9603462-C1C9-4C82-BB9E-546B04DCD948.dmp 09:36:31 INFO - Operating system: Mac OS X 09:36:31 INFO - 10.10.5 14F27 09:36:31 INFO - CPU: amd64 09:36:31 INFO - family 6 model 69 stepping 1 09:36:31 INFO - 4 CPUs 09:36:31 INFO - GPU: UNKNOWN 09:36:31 INFO - Crash reason: EXC_BAD_ACCESS / KERN_INVALID_ADDRESS 09:36:31 INFO - Crash address: 0x0 09:36:31 INFO - Process uptime: 25 seconds 09:36:31 INFO - Thread 0 (crashed) 09:36:31 INFO - 0 XUL!ProcessExecutableMemory::release() [ProcessExecutableMemory.cpp:033299f2733900eb0da9b5b4d814aea39ce552d4 : 492 + 0x0] 09:36:31 INFO - rax = 0x0000000000000000 rdx = 0x00007fff75f5c1f8 09:36:31 INFO - rcx = 0x0000000000000000 rbx = 0x0000000117fb6690 09:36:31 INFO - rsi = 0x0003c3000003c300 rdi = 0x0003c2000003c303 09:36:31 INFO - rbp = 0x00007fff50502dd0 rsp = 0x00007fff50502dc0 09:36:31 INFO - r8 = 0x00007fff50502d70 r9 = 0x00007fff75f86300 09:36:31 INFO - r10 = 0x0000000000000000 r11 = 0x0000000000000246 09:36:31 INFO - r12 = 0x000000011860a9d0 r13 = 0x00007fff50502e30 09:36:31 INFO - r14 = 0x0000000117fcd690 r15 = 0x00007fff50502e08 09:36:31 INFO - rip = 0x0000000114af2026 09:36:31 INFO - Found by: given as instruction pointer in context Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/30ed797c2454b1f5f259f1c26f85bd7a62380ef5 Push of the failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=033299f2733900eb0da9b5b4d814aea39ce552d4
Flags: needinfo?(peterv)
Flags: needinfo?(peterv)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: