1453016 - Reduce unsafe usage of integer->enum casts in IPC

Status: RESOLVED FIXED

(Core :: Graphics: Layers, enhancement, P1)

Description

[Alex Gaynor [:Alex_Gaynor]]

Graphics IPC uses |static_cast<gfx::SurfaceFormat>(aFormat)| in a handful of places in IPC which are unsafe under an adversarial content process, because it could send values that are outside the range of valid values.

I didn't spot any codepaths where this is necessarily exploitable, but there are a lot of them, so better safe than sorry :-)

Comment 1

[Alex Gaynor [:Alex_Gaynor]]

Attachment: Bug 1453016 - user safer enum serialization for gfx::SurfaceFormat in IPC;

Review commit: https://reviewboard.mozilla.org/r/235350/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/235350/

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8966638 [details]
Bug 1453016 - user safer enum serialization for gfx::SurfaceFormat in IPC;

https://reviewboard.mozilla.org/r/235350/#review241948

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3961427969b9
user safer enum serialization for gfx::SurfaceFormat in IPC; r=kats

Comment 4

[Bas Schouten (:bas.schouten)]

Comment on attachment 8966638 [details]
Bug 1453016 - user safer enum serialization for gfx::SurfaceFormat in IPC;

https://reviewboard.mozilla.org/r/235350/#review242194

Kats did this already, but yay, just for good measure :)

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/3961427969b9