1453061 - Cherry-pick aom and vpx code size fixes

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P2)

Description

[(Away)]

Bug 1445683 was supposed to bring us this fix, but it's stalled. Let's not block on it.

Note, this won't fix the orange in bug 1445922, but code size reduction is still good for its own sake!

Comment 1

[(Away)]

Attachment: Merge libaom code size fix

Comment 2

[(Away)]

Attachment: Merge libvpx code size fix

Comment 3

[Nils Ohlmeier [:drno]]

Comment on attachment 8966669 [details] [diff] [review]
Merge libaom code size fix

Review of attachment 8966669 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 4

[Nils Ohlmeier [:drno]]

Comment on attachment 8966670 [details] [diff] [review]
Merge libvpx code size fix

Review of attachment 8966670 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1edfe06dff5b
Merge libaom code size fix. r=drno
https://hg.mozilla.org/integration/mozilla-inbound/rev/6a08a9249650
Merge libvpx code size fix. r=drno

Comment 6

[Arthur Iakab [arthur_iakab]]

Backed out 2 changesets (bug 1453061)For frequently failing build bustage on win-32 pgo on a CLOSED TREE 
Link to the log:https://treeherder.mozilla.org/logviewer.html#?job_id=172953665&repo=mozilla-inbound
Backout revision https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=77dd8ec11ee1b936cb88c24961ef4cb5e281b391&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified

Failing push https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=6a08a924965023280eef73ee94ced91a30482575&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified

Comment 7

[(Away)]

Arthur, as I understand it, this PGO bustage (bug 1445922) was already quite common before my push.

Did my push make the bustage even more frequent? Can you please provide some numbers before and after? Thanks!

Comment 8

[(Away)]

Nevermind, I'll fix bug 1445922 and reland this.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0543a3f29a74
Merge libaom code size fix. r=drno
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d3b94d04760
Merge libvpx code size fix. r=drno

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0543a3f29a74
https://hg.mozilla.org/mozilla-central/rev/4d3b94d04760

Comment 11

[(Away)]

Backed out because the talos fileio test is currently broken by a taskcluster upgrade. Will re-land when we can get proper numbers on this.

https://hg.mozilla.org/integration/mozilla-inbound/rev/dceb884bab4d
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd3a8b247d77

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/dceb884bab4d
https://hg.mozilla.org/mozilla-central/rev/fd3a8b247d77

Comment 13

[Nils Ohlmeier [:drno]]

David are you still interested in re-landing this (I don't know what the status of Talos and the taskcluster upgrade is - is there a bug number for that we can make this depend on)?

Comment 14

[(Away)]

Eh, let's just land this, I'll measure by hand if I have to.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d6662030692
Merge libaom code size fix. r=drno
https://hg.mozilla.org/integration/mozilla-inbound/rev/7843bd47e547
Merge libvpx code size fix. r=drno

Comment 16

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/6d6662030692
https://hg.mozilla.org/mozilla-central/rev/7843bd47e547

Comment 17

[(Away)]

before this change (m-i 2dc0a563e958)
  win 2012 pgo
    installer 37,021 KB
    xul 69,409 KB
  win 2012 x64 pgo
    installer 39,872 KB
    xul 79,845 KB

with this change (m-i 7843bd47e547)
  win 2012 pgo
    installer 36,869 KB (-152 KB) (-0.4%)
    xul 67,927 KB (-1,482 KB) (-2.1%)
  win 2012 x64 pgo
    installer 39,785 KB (-87 KB) (-0.2%)
    xul 79,114 KB (-731 KB) (-0.9%)

Comment 18

[Tom Ritter [:tjr]]

Comment on attachment 8966669 [details] [diff] [review]
Merge libaom code size fix

[Approval Request Comment]

This is one of several MinGW Build patches I'd like to land in esr60 for Tor. It will prevent them from carrying their own patches for the lifetime of esr60 and will enable us to keep the MinGW build functioning and know if/when/how it was broken by new commits into esr60.

This commit affects all configurations; but if it were broken compilation would break.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8966669 [details] [diff] [review]
Merge libaom code size fix

Minor build config patch which makes downstream maintenance easier for Tor. Approved for ESR 60.2.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr60/rev/5f480411f545
https://hg.mozilla.org/releases/mozilla-esr60/rev/27b5a1a03f38