Closed Bug 1453061 Opened 2 years ago Closed 2 years ago

Cherry-pick aom and vpx code size fixes

Categories

(Core :: Audio/Video: Playback, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox-esr60 --- fixed
firefox62 --- fixed

People

(Reporter: dmajor, Assigned: dmajor)

References

Details

Attachments

(2 files)

Bug 1445683 was supposed to bring us this fix, but it's stalled. Let's not block on it.

Note, this won't fix the orange in bug 1445922, but code size reduction is still good for its own sake!
Attachment #8966669 - Flags: review?(drno)
Attachment #8966670 - Flags: review?(drno)
Comment on attachment 8966669 [details] [diff] [review]
Merge libaom code size fix

Review of attachment 8966669 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8966669 - Flags: review?(drno) → review+
Comment on attachment 8966670 [details] [diff] [review]
Merge libvpx code size fix

Review of attachment 8966670 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8966670 - Flags: review?(drno) → review+
Assignee: nobody → dmajor
Arthur, as I understand it, this PGO bustage (bug 1445922) was already quite common before my push.

Did my push make the bustage even more frequent? Can you please provide some numbers before and after? Thanks!
Flags: needinfo?(dmajor) → needinfo?(aiakab)
Nevermind, I'll fix bug 1445922 and reland this.
Flags: needinfo?(aiakab)
https://hg.mozilla.org/mozilla-central/rev/0543a3f29a74
https://hg.mozilla.org/mozilla-central/rev/4d3b94d04760
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Backed out because the talos fileio test is currently broken by a taskcluster upgrade. Will re-land when we can get proper numbers on this.

https://hg.mozilla.org/integration/mozilla-inbound/rev/dceb884bab4d
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd3a8b247d77
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
David are you still interested in re-landing this (I don't know what the status of Talos and the taskcluster upgrade is - is there a bug number for that we can make this depend on)?
Rank: 15
Flags: needinfo?(dmajor)
Priority: -- → P2
Eh, let's just land this, I'll measure by hand if I have to.
Flags: needinfo?(dmajor)
https://hg.mozilla.org/mozilla-central/rev/6d6662030692
https://hg.mozilla.org/mozilla-central/rev/7843bd47e547
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
before this change (m-i 2dc0a563e958)
  win 2012 pgo
    installer 37,021 KB
    xul 69,409 KB
  win 2012 x64 pgo
    installer 39,872 KB
    xul 79,845 KB

with this change (m-i 7843bd47e547)
  win 2012 pgo
    installer 36,869 KB (-152 KB) (-0.4%)
    xul 67,927 KB (-1,482 KB) (-2.1%)
  win 2012 x64 pgo
    installer 39,785 KB (-87 KB) (-0.2%)
    xul 79,114 KB (-731 KB) (-0.9%)
Blocks: 1471581
Comment on attachment 8966669 [details] [diff] [review]
Merge libaom code size fix

[Approval Request Comment]

This is one of several MinGW Build patches I'd like to land in esr60 for Tor. It will prevent them from carrying their own patches for the lifetime of esr60 and will enable us to keep the MinGW build functioning and know if/when/how it was broken by new commits into esr60.

This commit affects all configurations; but if it were broken compilation would break.
Attachment #8966669 - Flags: approval-mozilla-esr60?
Comment on attachment 8966669 [details] [diff] [review]
Merge libaom code size fix

Minor build config patch which makes downstream maintenance easier for Tor. Approved for ESR 60.2.
Attachment #8966669 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Attachment #8966670 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
You need to log in before you can comment on or make changes to this bug.