1453066 - Update Debugger Frontend v34

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Jason Laster [:jlast]]

https://github.com/devtools-html/debugger.html/compare/release-33...release-34

Comment 1

[Jason Laster [:jlast]]

Attachment: rel-34.patch

Comment 2

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=be955d9cd16e5b84984b1c6d050520c8836266af

Comment 3

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e2a37aa8613d01eba4c4f009757ddade7a2c6dfc

Comment 4

[Jason Laster [:jlast]]

try looks green, sans parseable-css.js which looks like my fault

> 0:19.21 TEST_END: Test OK. Subtests passed 0/2. Unexpected 2
> FAIL Got error message for chrome://devtools/skin/fonts.css: Error in parsing value for ‘flex-direction’.  Declaration dropped. -
> Stack trace:
> chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:messageIsCSSError:248
> chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:439FAIL All the styles (104) loaded without errors. - Got 1, expected 0
> Stack trace:
> chrome://mochikit/content/browser-test.js:test_is:1280
> chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:440

Comment 5

[Jason Laster [:jlast]]

nevrmind, parseable-css.js is something checked into tree

Comment 6

[Julian Descottes [:jdescottes]]

talos https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=9ba4ad66ff6897a544623c5735d3615d13990651&newProject=try&newRevision=37924aa35f2c7929d96ff4de0c4a3e1a591ef5ca&framework=1

Comment 7

[Julian Descottes [:jdescottes]]

Comment on attachment 8966684 [details] [diff] [review]
rel-34.patch

Review of attachment 8966684 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/64ef6909f615
Update Debugger Frontend v34. r=jdescottes

Comment 9

[Andreea Pavel [:apavel]]

Backed out for failing devtools/client/debugger/new/test/mochitest/browser_dbg-babel-preview.js 

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=64ef6909f615db406084de34e15c5ef25ed19b9b

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=173016880&repo=mozilla-inbound&lineNumber=3634

Backout:  https://hg.mozilla.org/integration/mozilla-inbound/rev/2bed6ea34a828b7ef19b89d1e7807b14c5badb4a

Comment 10

[Jason Laster [:jlast]]

I'm sorry for the timing issues. I verified the regression in 34 locally. When I rebased the commit off of current inbound the timing issues went away.

Comment 11

[Jason Laster [:jlast]]

another run - https://treeherder.mozilla.org/#/jobs?repo=try&revision=68852f4f73d4c19f52cba597d192db0bbeb9947f
w/ timeout -  https://treeherder.mozilla.org/#/jobs?repo=try&revision=0bc1525b700573c0a64510d9ccdb375c46cd5853

Comment 12

[Jason Laster [:jlast]]

here are some talos runs


baseline - remote:   https://treeherder.mozilla.org/#/jobs?repo=try&revision=949f2fd7a73bfbe9b20e7e6cfb40ab982ad1c05b
34 - https://treeherder.mozilla.org/#/jobs?repo=try&revision=c35de6b52c1183813cf2a3a1eeaea01eedbc3273
sans wasm - https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d52bba0735f3a9ad7a20843687e74ddb14cfcbf

Comment 13

[Jason Laster [:jlast]]

and a new try w/ a longer babel-scopes:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a78d3315a819154f40662b3a039638b7ba7fd8e1

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fbbc76f40fcc
Update Debugger Frontend v34. r=jdescottes

Comment 15

[Jason Laster [:jlast]]

I landed 34 with the perf regressions and will work on analyzing the regressions:

sans wasm comparison -  https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&originalRevision=949f2fd7a73bfbe9b20e7e6cfb40ab982ad1c05b&newProject=try&newRevision=3d52bba0735f3a9ad7a20843687e74ddb14cfcbf&originalSignature=28c4fee1ef7d4e5d184aa628df7c94de208b7678&newSignature=28c4fee1ef7d4e5d184aa628df7c94de208b7678&framework=1

34 comparison - https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&originalRevision=949f2fd7a73bfbe9b20e7e6cfb40ab982ad1c05b&newProject=try&newRevision=c35de6b52c1183813cf2a3a1eeaea01eedbc3273&originalSignature=28c4fee1ef7d4e5d184aa628df7c94de208b7678&newSignature=28c4fee1ef7d4e5d184aa628df7c94de208b7678&framework=1


looks like it's real and not wasm...

Comment 16

[Jason Laster [:jlast]]

selective: https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=e3bf5a335ad72112fbcf77ca1111caa9b0b635b5

- roots
- auto expand
- [Preview] stop showing preview

Comment 17

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cedd9712c8bca3fc7240e206b84ab40b2ead79bc

first 1/2 of commits

0aeeee8 Remove all references to Firebug theme (#5883)
1d3f6ba [Sources] Auto expand path of selected source (#5716)
b15c280 Prevent selection of breakpoint contents (#5879)
a460b03 [QuickOpen] Path is too wide #5860 (#5868)
211d16f Update wasmparser to the latest version 

Comment 18

[Jason Laster [:jlast]]

selective is probably not clear, what I meant to say was. this commit includes all of 34 sans those 3 commits for webpack roots, auto expand and preview showing all original files.

Comment 19

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/fbbc76f40fcc

Comment 20

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/perf.html#/comparechooser?newProject=try&newRevision=83b3828d3d79253e6577a2522e8b85da50bf114a