1453128 - Fix Acer locale problem using target system add-on

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Mike Kaply [:mkaply]]

For background, see:

https://bugzilla.mozilla.org/show_bug.cgi?id=1450270

Due to the change from general.useragent.locale to intl.locale.requested, we broke non-US Acer preloads.

Since that fix won't be available until Firefox 60, I'd like to use a targeted system add-on to fix this problem only on Acer machines.

We can target Acer specifically using the distribution ID of acer-001.

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

We will to set up the system addon on a test channel,
That's described briefly here, https://wiki.mozilla.org/Firefox/Go_Faster/System_Add-ons/Process#Deployed_to_Test_Channel 

Rehan, can you help with that? The add-on code is here, https://github.com/mozilla/one-off-system-add-ons/pull/103

Then get QA to verify on the test channel with an Acer device from an affected locale.

STR are in https://bugzilla.mozilla.org/show_bug.cgi?id=1450270#c19

Comment 2

[Liz Henry (:lizzard) (relman/hg->git project)]

Tom, do you want Mike to do a PI request here or is it enough to n-i you or Andrei in this bug?

Since this is for a problem on the release channel, I'm hoping we can give this a high priority.

Comment 3

[Rehan Dalal (Inactive)]

I need a signed XPI to move this to Balrog.

Mike could you attach an unsigned XPI and NI :jason or :wezhou to sign it?

Comment 4

[Mike Kaply [:mkaply]]

Attachment: acer-locale-fix.xpi

Addon for signing.

Comment 5

[Mike Kaply [:mkaply]]

Adding Jason too. Having trouble getting a hold of wezhou.

Comment 6

[Tom Grabowski [:TomGrab]]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #2)
> Tom, do you want Mike to do a PI request here or is it enough to n-i you or
> Andrei in this bug?
> 
> Since this is for a problem on the release channel, I'm hoping we can give
> this a high priority.

Please file a PI request and reference this ticket. It takes two minutes to file a PI request, and it assures that the proper process is followed and QA resources are assigned and tracked.
You can follow the steps in here: https://mana.mozilla.org/wiki/display/PI/PI+Request

Comment 7

[Mike Kaply [:mkaply]]

I have filed the PI requested and already been in contact with the tester.

Comment 8

[Jason Thomas [:jason]]

Attachment: acer-locale-fix.xpi signed

Please see attached. :wezhou is on PTO this week.

Comment 9

[Rehan Dalal (Inactive)]

This should now be live on the test channel (release-sysaddon) and is pending relman sign off on the release channel.

Comment 10

[Mike Kaply [:mkaply]]

I've tested locally and it's working for me. Once QA has signed off, we should be good. I've pinged StefanG

Comment 11

[Stefan [:StefanG_QA]]

We've managed to reproduce this bug using Firefox 59.0.2 (64/32 bit) on Windows 10 x64. After installing different language packs, the language did not change to the installed languages.

We've retested on Windows 10 x64 using Fx 59 (64/32 bit) with installed German, Bulgarian or Russian language packs. The bug is not reproducing anymore. The browser changed the language to the one noted in general.useragent.locale in distribution file and the pref intl.locale.requested is changed to the same locale.

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

I signed off in balrog just now, so this fix should be available to users soon.

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

This shipped on Wednesday.

Comment 14

[Mike Kaply [:mkaply]]

Partner and I have both verified.

Thank you!