Closed Bug 1453189 Opened 6 years ago Closed 6 years ago

Fix django-filters Filter.name DeprecationWarnings

Categories

(Tree Management :: Treeherder: API, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

Enabling deprecation warnings and running `./manage.py runserver` (or virtually any other command), gives:

/home/vagrant/treeherder/treeherder/webapp/api/jobs.py:41: DeprecationWarning: `Filter.name` has been renamed to `Filter.field_name`. See: https://django-filter.readthedocs.io/en/develop/migration.html
  id = django_filters.NumberFilter(name='id')
/home/vagrant/python/lib/python2.7/site-packages/django_filters/filters.py:551: DeprecationWarning: `Filter.name` has been renamed to `Filter.field_name`. See: https://django-filter.readthedocs.io/en/develop/migration.html
  super(BaseCSVFilter, self).__init__(*args, **kwargs)
/home/vagrant/treeherder/treeherder/webapp/api/jobs.py:45: DeprecationWarning: `Filter.name` has been renamed to `Filter.field_name`. See: https://django-filter.readthedocs.io/en/develop/migration.html
  job_guid = django_filters.CharFilter(name='guid')
/home/vagrant/treeherder/treeherder/webapp/api/jobs.py:48: DeprecationWarning: `Filter.name` has been renamed to `Filter.field_name`. See: https://django-filter.readthedocs.io/en/develop/migration.html
  name='build_platform__architecture')
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/18628848f40f9bd767dcdbcc0aad6df5b31cd33b
Bug 1453189 - Stop using deprecated django-filters 'Filter.name'

Fixes dozens of deprecation warnings of form:
```
treeherder/webapp/api/jobs.py:41: DeprecationWarning: `Filter.name`
has been renamed to `Filter.field_name`. See:
https://django-filter.readthedocs.io/en/develop/migration.html
  id = django_filters.NumberFilter(name='id')
```
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.